Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aria1.0 combobox autocomplete both example: When edit not empty and matches appear, Up Arrow does not set activedescendant to last match in list #821

Closed
spectranaut opened this issue Aug 2, 2018 · 6 comments
Closed

aria1.0 combobox autocomplete both example: When edit not empty and matches appear, Up Arrow does not set activedescendant to last match in list #821

spectranaut opened this issue Aug 2, 2018 · 6 comments
Assignees
@jongund
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Milestone
1.1 APG Release 3

Comments

@spectranaut
Copy link
Contributor

spectranaut commented Aug 2, 2018 •
edited
Loading

Hey all, there is a bug with aria-activedescendent in the aria 1.0 combobox-autocomplete-both example.

To replicate:

  1. focus on the textbox
  2. Type "a"
  3. Press "up arrow"
    a. Notice that aria-activedescendent is not set on the textbox although the first entry is highlighted and autocompleted in the textbox. It looks as if visual focus is on the textbox still as well

Note that "down arrow" works if you use it instead of up arrow in step 3 above.

This bug was caught by writing tests! :)
@mcking65
Copy link
Contributor

mcking65 commented Aug 2, 2018

Interesting ... The value changes to Arkansas, but activedescendant is not set to point to Arkansas.

Unlike down arrow, I also see that the keyboard table entry for up arrow only describes what happens when the text box is empty, it does not say anything about what will happen when it is not empty. That implies nothing would happen. However, the current behavior of moving to the last value in the popup seems reasonable.

@jongund, @accdc, do you have thoughts on this?

@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern Needs Review labels Aug 2, 2018
@mcking65 mcking65 added this to the 1.1 APG Release 3 milestone Aug 2, 2018
@jongund
Copy link
Contributor

jongund commented Aug 3, 2018

Just so I understand the aria-activedescendant should point to any exact match of an option in the list with the textbox value?

Jon

@mcking65
Copy link
Contributor

mcking65 commented Aug 3, 2018

Just so I understand the aria-activedescendant should point to any exact match of an option in the list with the textbox value?

No ... there are times where there is a match but focus is in the textbox. We don't want to change that.

This is only about whether up arrow sets activedescendant if it was not previously set. It is happening when the textbox is empty, but not when the textbox contains a matching substring.

The question is whether we think up arrow should do that. It seems logical to me; it would be the inverse of down arrow, which seems appropriate given that up/down mirror each other when the textbox is empty. So, why not mirror each other when the textbox contains a string that matches a set of one or more options.

@jongund
Copy link
Contributor

jongund commented Aug 3, 2018

I will look into adding up arrow

@spectranaut spectranaut mentioned this issue Aug 16, 2018
Merged
@mcking65 mcking65 changed the title Bug in example combobox/aria1.0pattern/combobox-autocomplete-both.html: aria-activedescendant not set aria1.0 combobox autocomplete both example: When edit not empty and matches appear, Up Arrow does not set activedescendant to last match in list Aug 26, 2018
@jongund
Copy link
Contributor

jongund commented Aug 27, 2018

Fixed in pull request #857

mcking65 pushed a commit that referenced this issue Sep 13, 2018
@jongund @mcking65
aria1.0 combobox with autocomplete=both example: Make Up Arrow set ac…
18eacf8 
…tivedescendant to last match in list (pull #857)

To address issue #821, make the up arrow behavior when a match exists consistent with when text box is empty.
michael-n-cooper pushed a commit that referenced this issue Sep 13, 2018
Generated by TRAVIS-CI 18eacf8
aa71786 
aria1.0 combobox with autocomplete=both example: Make Up Arrow set activedescendant to last match in list (pull #857)

To address issue #821, make the up arrow behavior when a match exists consistent with when text box is empty.
mcking65 added a commit that referenced this issue Sep 13, 2018
@mcking65
aria1.0 combobox autocomplete list and both examples: Correct up arro…
8557ab7 
…w documentation for the textbox

Commit 18eacf8 for issue #821 fixes the behavior of the up arrow when the combobox is not empty and the listbox is open and displays suggested values.
This commit corrects the documentation so that it accurately describes the adjusted behavior.
modified:   examples/combobox/aria1.0pattern/combobox-autocomplete-both.html
modified:   examples/combobox/aria1.0pattern/combobox-autocomplete-list.html
michael-n-cooper pushed a commit that referenced this issue Sep 13, 2018
Generated by TRAVIS-CI 8557ab7
6ac6ff5 
aria1.0 combobox autocomplete list and both examples: Correct up arrow documentation for the textbox

Commit 18eacf8 for issue #821 fixes the behavior of the up arrow when the combobox is not empty and the listbox is open and displays suggested values.
This commit corrects the documentation so that it accurately describes the adjusted behavior.
modified:   examples/combobox/aria1.0pattern/combobox-autocomplete-both.html
modified:   examples/combobox/aria1.0pattern/combobox-autocomplete-list.html
@mcking65
Copy link
Contributor

@jongund, thank you for your help with this.
@spectranaut, is there any f/o action on the test side here?
I'm closing this one as it is resolved.

spectranaut pushed a commit to bocoup/aria-practices that referenced this issue Sep 13, 2018
@jongund
aria1.0 combobox with autocomplete=both example: Make Up Arrow set ac…
68df329 
…tivedescendant to last match in list (pull w3c#857)

To address issue w3c#821, make the up arrow behavior when a match exists consistent with when text box is empty.
spectranaut pushed a commit to bocoup/aria-practices that referenced this issue Sep 13, 2018
@mcking65
aria1.0 combobox autocomplete list and both examples: Correct up arro…
54fd3dc 
…w documentation for the textbox

Commit 18eacf8 for issue w3c#821 fixes the behavior of the up arrow when the combobox is not empty and the listbox is open and displays suggested values.
This commit corrects the documentation so that it accurately describes the adjusted behavior.
modified:   examples/combobox/aria1.0pattern/combobox-autocomplete-both.html
modified:   examples/combobox/aria1.0pattern/combobox-autocomplete-list.html
spectranaut pushed a commit to bocoup/aria-practices that referenced this issue Sep 14, 2018
@jongund
aria1.0 combobox with autocomplete=both example: Make Up Arrow set ac…
2ec6edd 
…tivedescendant to last match in list (pull w3c#857)

To address issue w3c#821, make the up arrow behavior when a match exists consistent with when text box is empty.
spectranaut pushed a commit to bocoup/aria-practices that referenced this issue Sep 14, 2018
@mcking65
aria1.0 combobox autocomplete list and both examples: Correct up arro…
954b9b7 
…w documentation for the textbox

Commit 18eacf8 for issue w3c#821 fixes the behavior of the up arrow when the combobox is not empty and the listbox is open and displays suggested values.
This commit corrects the documentation so that it accurately describes the adjusted behavior.
modified:   examples/combobox/aria1.0pattern/combobox-autocomplete-both.html
modified:   examples/combobox/aria1.0pattern/combobox-autocomplete-list.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongund jongund

Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Projects
None yet
Milestone
1.1 APG Release 3
Development

No branches or pull requests
3 participants
@spectranaut @jongund @mcking65