-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code guide: Use short encoding declaration and avoid /> #2069
Conversation
PR for |
The PR for |
9584c55
to
4977db4
Compare
<head> | ||
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> | ||
<html lang="en-US"><head> | ||
<meta charset="UTF-8"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in the other files the lowercase "utf-8" is used, but that it doesn't make a functional difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I don't care about casing here...
@@ -143,26 +143,26 @@ <h3>Source Code</h3> | |||
<div class="code"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an actual code block instead of escaped HTML in a div?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in this PR. 🙂 Feel free to file an issue, though I guess the landmark pages need an overhaul and this would be fixed as part of that when we get to it.
package-lock.json
Outdated
@@ -1,8 +1,10288 @@ | |||
{ | |||
"name": "aria-practices", | |||
"version": "0.0.0", | |||
"lockfileVersion": 1, | |||
"lockfileVersion": 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading the lockfile might make sense, but probably better to do it separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is now merged, so this needs a rebase. cc @howard-e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
3e5258f
to
868d6a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
package.json
Outdated
@@ -49,7 +49,7 @@ | |||
"eslint-plugin-prettier": "^4.0.0", | |||
"geckodriver": "^1.22.1", | |||
"glob": "^7.1.6", | |||
"htmlhint": "^0.14.2", | |||
"htmlhint": "^0.16.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the package-lock.json changes can be rebased out now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Think we can land this afterwards
This rule checks that HTML void elements do not use '/>' syntax.
Co-authored-by: Michael "Z" Goddard <mzgoddard@gmail.com>
c464807
to
bc8f78b
Compare
package-lock.json
Outdated
"version": "2.0.1", | ||
"resolved": "https://registry.npmjs.org/nth-check/-/nth-check-2.0.1.tgz", | ||
"integrity": "sha512-it1vE95zF6dTT9lBsYbxvqh0Soy4SPowchj0UBGj/V6cTPnXXtQOPUbhZ6CmGzAD/rW22LQK6E96pcdJXk4A4w==", | ||
"version": "2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked like it reverted some of your latest landed PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd, will take another look at that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you just need to rebase off the last commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be good now. It seems running npm install
currently will revert some references of nth-check
and trim-newlines
. An npm audit fix
should correct the lockfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@howard-e you seem comfortable with rebase, so this git alias might be handy for you https://github.com/nschonni/dotfiles/blob/0095dfa25aabf67d3682a792670e042abba2ec62/.gitconfig#L26. It works on repos, no mater what the default branch name is 😉 |
Appreciate that! |
bc8f78b
to
edccb22
Compare
* Use short encoding declaration and avoid />. Don't include a trailing slash in self-closing elements—the HTML standard says they're optional. * Use htmlhint 'empty-tag-not-self-closed' rule. This rule checks that HTML void elements do not use '/>' syntax. Co-authored-by: Michael "Z" Goddard <mzgoddard@gmail.com> Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
<meta charset="UTF-8">
https://github.com/w3c/aria-practices/wiki/Code-Guide#character-encodingI looked into adding a lint for
/>
withhtmlhint
, but it seems to not be implemented: htmlhint/HTMLHint#337 (comment)Preview | Diff