Landmark examples: Update links to related documents and SkipTo script

[jongund]

Also made some minor edits to the resources page

---

WAI Preview Link (Last built on Sun, 11 Jun 2023 00:58:36 GMT).

[css-meeting-bot]

The ARIA Authoring Practices (APG) Task Force just discussed Landmark examples: Updated SkipTo script and configuration by jongund · Pull Request #2624 · w3c/aria-practices.

The full IRC log of that discussion

<jugglinmike> subtopic: Landmark examples: Updated SkipTo script and configuration by jongund · Pull Request #2624 · w3c/aria-practices
<jugglinmike> github: https://github.com//pull/2624
<jugglinmike> jongund: We've been using a very old version of skipto
<jugglinmike> Matt_King: I'd like to hold off on this one for about a week. After that week, we may have to rebase or merge in the "main" branch

[css-meeting-bot]

The ARIA Authoring Practices (APG) Task Force just discussed Landmark examples: Updated SkipTo script and configuration by jongund · Pull Request #2624 · w3c/aria-practices.

The full IRC log of that discussion

<jugglinmike> Subtopic: Landmark examples: Updated SkipTo script and configuration by jongund · Pull Request #2624 · w3c/aria-practices
<jugglinmike> github: https://github.com//pull/2624
<jugglinmike> Matt_King: I think this is waiting on me
<jugglinmike> Jem: Two regression tests failed
<jugglinmike> Matt_King: Occassionally there are timing issues, and sometimes they'll pass if you just have them run again (e.g. by pushing another commit to the pull request's branch)

[css-meeting-bot]

The ARIA Authoring Practices (APG) Task Force just discussed Landmark examples: Updated SkipTo script and configuration by jongund · Pull Request #2624 · w3c/aria-practices.

The full IRC log of that discussion

<jugglinmike> Subtopic: Landmark examples: Updated SkipTo script and configuration by jongund · Pull Request #2624 · w3c/aria-practices
<jugglinmike> github: https://github.com//pull/2624
<jugglinmike> Matt_King: I haven't gotten to this yet, so we'll keep it on the list

[css-meeting-bot]

The ARIA Authoring Practices (APG) Task Force just discussed Landmark examples: Updated SkipTo script and configuration.

The full IRC log of that discussion

<jugglinmike> subtopic: Landmark examples: Updated SkipTo script and configuration
<jugglinmike> github: https://github.com//pull/2624
<jugglinmike> jongund: This is a simple fix
<jugglinmike> Matt_King: Kurt, I may assign this to you, but we can include it in next week's agenda
<jugglinmike> jongund: This solution works for this example. I don't know if it work in a general way

[jongund]

@mcking65
Not sure why one of the regression tests is failing for toolbar, none of the toolbar files were changed in this pull request.

[howard-e]

@jongund I I'm assuming it's a flaky test because the related pull_request action ran successfully, but the push action did not. So I went ahead and re-ran the action (and it now passes).

For context, the error was reported as a timeout by the test runner.

Error:

not ok 92 - toolbar_toolbar › content/patterns/toolbar/examples/toolbar.html [data-test-id="toolbar-menuitemradio-aria-checked"]: menuitemradio elements have aria-checked set
  ---
    name: AssertionError
    message: Rejected promise returned by test
    values:
      'Rejected promise returned by test. Reason:': |-
        TimeoutError {
          remoteStacktrace: '',
          message: `Waiting for menu to open␊
          Wait timed out after 10141ms`,
        }
    at: |-
      Wait timed out after 10141ms
      node_modules/selenium-webdriver/lib/webdriver.js:929:17
      runMicrotasks (<anonymous>)
  ...

[jongund]

@howard-e
Thank you for fixing the problem. I tired rerunning the tests, but it still reported the problem.

[jongund]

@howard-e
I made an update on this pull request, but the preview links failed to be created.
Who can look into this?

[howard-e]

@jongund the error described in the failed build, under the 'Update site files' step is:

Error:

/home/runner/work/wai-aria-practices/wai-aria-practices/scripts/pre-build/library/determineContentType.js:48
throw new Error(
^

Error: Could not determine content type for file at /home/runner/work/wai-aria-practices/wai-aria-practices/_external/aria-practices/content/about/introduction/introduction.html
This file may not follow established conventions.
at determineContentType (/home/runner/work/wai-aria-practices/wai-aria-practices/scripts/pre-build/library/determineContentType.js:48:9)

The condition for this happening seems related to w3c/wai-aria-practices#219 since that w3c/wai-aria-practices has been updated recently.

I've manually updated the generated PR, w3c/wai-aria-practices#198 and re-ran the action, so the link is now available again.