Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Most of ARIA reflection attributes must have CEReactions extended IDL attribute #1767

Closed
rniwa opened this issue Jul 16, 2022 · 2 comments
Closed

Most of ARIA reflection attributes must have CEReactions extended IDL attribute #1767

rniwa opened this issue Jul 16, 2022 · 2 comments

Comments

@rniwa
Copy link

rniwa commented Jul 16, 2022

Since ARIA reflection attributes such as ariaLabel mutate element's content attribute, they must have CEReactions extended IDL attribute.
@rniwa rniwa mentioned this issue Jul 16, 2022
Merged
@pkra
Copy link
Member

pkra commented Jul 16, 2022

Is this a duplicate of #1242? (Recent PR for that is at #1766.)

@rniwa
Copy link
Author

rniwa commented Jul 16, 2022

Indeed, it is! It's a shame we had that issue filed last year and didn't fix it until now!

@rniwa rniwa closed this as completed Jul 16, 2022
webkit-early-warning-system pushed a commit to rniwa/WebKit that referenced this issue Jul 17, 2022
@rniwa
ASSERTION FAILED: !m_invoking in CustomElementQueue::add() on tv.yout…
a0165ae 
…ube.com

https://bugs.webkit.org/show_bug.cgi?id=237977

Reviewed by Wenson Hsieh.

The assertion failure was caused by ARIA reflection attributes not having CEReactions.
Fixed the bug and filed a spec bug: w3c/aria#1767

* LayoutTests/fast/custom-elements/reactions-for-aria-attributes-expected.txt: Added.
* LayoutTests/fast/custom-elements/reactions-for-aria-attributes.html: Added.
* LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes-expected.txt: Added.
* LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes.html: Added.
* Source/WebCore/accessibility/AriaAttributes.idl:

Canonical link: https://commits.webkit.org/252552@main
Jarred-Sumner pushed a commit to oven-sh/WebKit that referenced this issue Jul 27, 2022
@rniwa @Jarred-Sumner
ASSERTION FAILED: !m_invoking in CustomElementQueue::add() on tv.yout…
dc7d867 
…ube.com

https://bugs.webkit.org/show_bug.cgi?id=237977

Reviewed by Wenson Hsieh.

The assertion failure was caused by ARIA reflection attributes not having CEReactions.
Fixed the bug and filed a spec bug: w3c/aria#1767

* LayoutTests/fast/custom-elements/reactions-for-aria-attributes-expected.txt: Added.
* LayoutTests/fast/custom-elements/reactions-for-aria-attributes.html: Added.
* LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes-expected.txt: Added.
* LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes.html: Added.
* Source/WebCore/accessibility/AriaAttributes.idl:

Canonical link: https://commits.webkit.org/252552@main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rniwa @pkra