-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment role #1135
Add comment role #1135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Discussed during call:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to use the suggestion feature to propose changes. It got a bit tricky though because I made some suggestions that only work if accepted as a set.
My suggestions do not address all the issues. In particular, I am unclear about relationships among hierarchical comments when not all comment elements are present in the DOM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much cleaner and easier to understand now. I have a few editorial suggestions And one substantive suggestion that we not require role complementary for a container.
I wonder if screen readers would really want to probe every use of aria-details referring to an element that is not a specific annotation type to find out whether it is a general description or a container of specific annotation types. If they have no problem with that, then there would be no use for a property like aria-containsannotations. So, whether it would add value is really a question for screen reader devs. |
Good question. If the container had a label, then the user might benefit more from hearing the container's label than from hearing about detailed annotation types within the container? For example, if a complementary region was the target of an aria-details, and the author added a nice visible label saying 24 comments on "Dogs and their Owners" then would the user prefer to hear that label before navigating there, or something like "contains comments" or "contains 24 comments"?
|
Matt, I took your suggestions except for complementary. I think there is value in requiring a specific role for a grouping element for comments. This will make it easier for the user agent to know when to bother computing a "hascomments" object attribute hint. |
@mcking65 can you take a look. I need to merge this one before I merge aria-details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the wording should be more clear. I made a suggestion.
Refers to issue #749
Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Co-Authored-By: Matt King <a11yThinker@Gmail.com>
Co-Authored-By: Matt King <a11yThinker@Gmail.com>
Co-Authored-By: Matt King <a11yThinker@Gmail.com>
Co-Authored-By: Matt King <a11yThinker@Gmail.com>
7a49289
to
75a6436
Compare
Refers to issue #749 Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com> Co-Authored-By: Matt King <a11yThinker@Gmail.com>
Refers to issue #749
Preview | Diff