editorial: Modernize and replace prose with algorithms in BatteryManager #46

rakuco · 2021-09-01T12:51:48Z

Similarly to #45, make the BatteryManager section more conformant to
modern spec writing practices, while avoiding making user-visible changes as
much as possible:

Define a task source for this spec, and switch from "queue a task" to the
more specific and recent "queue a global task" algorithm.
Replace a lot of prose with internal slots and algorithms.
Make the interface attributes simply return the values of the internal
slots rather than defining logic in their getters.
Define an actual algorithm for updating internal slots and dispatching
events. The existing prose just said "the UA must change the attribute and
fire an event" without really defining how to reach a BatteryManager
object in the first place.

Preview | Diff

rakuco · 2021-09-01T12:53:04Z

@reillyeon @marcoscaceres
This one is bigger than #45, so some extra pairs of eyes are appreciated.

index.html

marcoscaceres · 2021-09-02T06:49:43Z

Will try to review soon!

anssiko · 2021-09-02T06:59:29Z

I authorize @reillyeon to merge this PR once we get @marcoscaceres's eyeballs on it.

Similarly to w3c#45, make the `BatteryManager` section more conformant to modern spec writing practices, while avoiding making user-visible changes as much as possible: - Define a task source for this spec, and switch from "queue a task" to the more specific and recent "queue a global task" algorithm. - Replace a lot of prose with internal slots and algorithms. - Make the interface attributes simply return the values of the internal slots rather than defining logic in their getters. - Define an actual algorithm for updating internal slots and dispatching events. The existing prose just said "the UA must change the attribute and fire an event" without really defining how to reach a `BatteryManager` object in the first place.

index.html

marcoscaceres

Overall looks good @rakuco! Just some suggestions, but a vast improvement! keep it up!

The contents are essentially the same as the normative descriptions in the subsequent section.

Refer to the Web IDL interface rather than the BatteryManager concept.

index.html

…dler table.

rakuco · 2021-09-09T13:41:03Z

thanks for reviewing, @reillyeon and @marcoscaceres

I'd appreciate it if someone could merge this PR

anssiko · 2021-09-09T14:29:29Z

Thanks @rakuco! You should add yourself to the editors if you plan to keep an eye on this spec. Otherwise, we’ll give you huge credits in the ack section for these modernizations.

rakuco · 2021-09-09T14:35:18Z

So far I've just been trying to catch up with the backlog of things I'd promised to do back in April during the DAS WG virtual meeting :-) Once I finish making the spec look better (and hopefully address #15) I can consider officially becoming an editor.

rakuco force-pushed the editorial/modernize-BatteryManager-section branch from df61e14 to 7cbd8d2 Compare September 1, 2021 12:55

reillyeon requested changes Sep 2, 2021

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

rakuco force-pushed the editorial/modernize-BatteryManager-section branch from 7cbd8d2 to 79ec094 Compare September 2, 2021 07:43