-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automation section and WebDriver support #265
Commits on May 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 18ed9ce - Browse repository at this point
Copy the full SHA 18ed9ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for da611a0 - Browse repository at this point
Copy the full SHA da611a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebb89c3 - Browse repository at this point
Copy the full SHA ebb89c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 109fd78 - Browse repository at this point
Copy the full SHA 109fd78View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae4875c - Browse repository at this point
Copy the full SHA ae4875cView commit details -
Redefing platform collector and let it use virtual sources
- there is one platform collector per global object (GO) - a platform collector will use virtual sources for non-worker GOs - virtual sources update data at a given sample rate set when created - pressure observers collect data at their own given sample rate
Configuration menu - View commit details
-
Copy full SHA for dff5fca - Browse repository at this point
Copy the full SHA dff5fcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8f8afc - Browse repository at this point
Copy the full SHA c8f8afcView commit details
Commits on May 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ba6ccbd - Browse repository at this point
Copy the full SHA ba6ccbdView commit details
Commits on May 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ebb75c8 - Browse repository at this point
Copy the full SHA ebb75c8View commit details
Commits on May 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4521ec4 - Browse repository at this point
Copy the full SHA 4521ec4View commit details
Commits on May 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3dbb088 - Browse repository at this point
Copy the full SHA 3dbb088View commit details -
Configuration menu - View commit details
-
Copy full SHA for c92a958 - Browse repository at this point
Copy the full SHA c92a958View commit details -
Remove virtual pressure source's source type property
It was not being used anywhere; the source type is always when manipulating the virtual pressure source mapping, which uses source types as keys.
Configuration menu - View commit details
-
Copy full SHA for 1768ef5 - Browse repository at this point
Copy the full SHA 1768ef5View commit details -
Use data-dfn-for for concepts scoped to virtual pressure source
This makes it more clear when writing the spec that this is a concept related to a virtual pressure source rather than a general one.
Configuration menu - View commit details
-
Copy full SHA for 417dcb4 - Browse repository at this point
Copy the full SHA 417dcb4View commit details -
Move retrieval of a virtual pressure source from a global to a separa…
…te algorithm This makes it possible to invoke it from multiple locations in preparation for supporting adding a virtual pressure source that reports itself as non-existent. While here: add `class="algorithm"` to the "data collection" algorithm.
Configuration menu - View commit details
-
Copy full SHA for 8b8f282 - Browse repository at this point
Copy the full SHA 8b8f282View commit details -
virtual pressure source: Add "can provide samples flag" boolean
This flag can be set in the "create virtual pressure source" endpoint, where it is set to true by default. When false, it causes calls to PressureObserver.observe() to reject with NotSupportedError when attempting to use the given virtual pressure source.
Configuration menu - View commit details
-
Copy full SHA for afcabae - Browse repository at this point
Copy the full SHA afcabaeView commit details -
get virtual pressure source: Add assertion for owningDocument's size
Merely for readability; if we reach the assertion, it means there must be exactly one element in the owning set (only shared workers would have more than one owning document).
Configuration menu - View commit details
-
Copy full SHA for 8e9809c - Browse repository at this point
Copy the full SHA 8e9809cView commit details -
Improvements to the "data collection" algorithm from my PR review
- Get rid of `|data|` altogether. Specifying a return variable in the algorithm declaration is at the very least unusual. Furthermore, `|data|` and `|state|` were serving the same purpose in the virtual pressure source case while not working correctly in the non-virtual one at all: in the non-virtual case, `|data|` would always be null and the entire algorithm would abort. Furthermore, even if it did not, the subsequent step was reading `|data|` without ever writing to it first. - Stop setting a virtual platform sensor's "pending sample" to null after reading it. It is not necessary; if the same sample is sent on a later call, the other algorithms (like "has change in data") should take care of ignoring it instead. - Formatting: add missing `<p></p>` tags to the `<aside>` block.
Configuration menu - View commit details
-
Copy full SHA for 6165314 - Browse repository at this point
Copy the full SHA 6165314View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a5757a - Browse repository at this point
Copy the full SHA 4a5757aView commit details
Commits on Jun 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4f79b62 - Browse repository at this point
Copy the full SHA 4f79b62View commit details
Commits on Jun 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for df35c2b - Browse repository at this point
Copy the full SHA df35c2bView commit details -
Fix platform collector cardinality, define pressure source and activa…
…tion/deactivation This addresses w3c#265 (comment) by properly defining several concepts in one change: - "Pressure source" is now a proper `<dfn>`. It is similar to a "device sensor" in the Generic Sensor API spec, in that it works as the concept closest to the OS/hardware and retrieves some abstract telemetry data that is fed to one or more platform collectors. A virtual pressure source is a pressure source. - Platform collector's granularity has been fixed: there isn't one per global, but rather one per source type. To make it easier to follow, a global now has a "platform collector mapping" rather than just an associated platform collector. - Each platform collector now has some associated data: an "associated pressure source", which is the pressure source it retrieves data from, as well as an "activated" flag that is used when activating/deactivating data collection. With these new building blocks, we can fix and/or properly define some concepts that have been unclear so far: - A null associated pressure source indicates that a given pressure source is not available. This is used, for example, in `PressureObserver.observe()`, which is now responsible for creating a platform collector when one is not available in its global and attempting to set the platform collector's associated pressure source to either a virtual pressure source or a real one. When neither can be found, it remains null, which signals that `observe()` must reject with NotSupportedError. Previously (see w3c#273), the `observe()` steps simply checked if `|source|` was a "valid source type", which did not properly reflect the potentially asynchronous checks involved in the real pressure source case. - The absence of an entry for a given source type in the "platform collector mapping" indicates that `PressureObserver.observe()` must attempt to create a new platform collector as described above. An existing "platform collector mapping" entry is removed only by calls to `disconnect()` and `unobserve()` as well as when a document is no longer fully active or a worker's closing flag is set to true. Conceptually, this indicates more clearly that once a platform collector is created in `observe()` it will continue using the same associated pressure source. In other words, if `observe()` is called before "create virtual pressure source", all observers for the same source type will continue using a real pressure source until they all disconnect (and vice-versa). - A virtual pressure source keeps track of connected platform collectors so that it can set their associated pressure source to null when it is removed before they disconnect. This is used in the new data collection algorithm described below. - The data collection steps have been revamped. - "Data collection" itself has not changed much: it tries to get a platform collector's pressure source if one exists, read data from it and dispatch it to observers. - We finally have proper definitions for what it means to activate and deactivate data collection. The steps themselves do not do much besides making sure 1) a platform collector for the desired source exists and 2) these steps cannot run more than once for a platform collector. The "deactivate data collection" steps also takes care of removing a collector from a virtual pressure source's connected platform collectors set.
Configuration menu - View commit details
-
Copy full SHA for c01a9a9 - Browse repository at this point
Copy the full SHA c01a9a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e45f07 - Browse repository at this point
Copy the full SHA 9e45f07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 126995b - Browse repository at this point
Copy the full SHA 126995bView commit details
Commits on Jun 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 19e894e - Browse repository at this point
Copy the full SHA 19e894eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 308640a - Browse repository at this point
Copy the full SHA 308640aView commit details -
Rename "can provide samples flag" to "can provide samples"
As suggested by @kenchris.
Configuration menu - View commit details
-
Copy full SHA for cfd84d0 - Browse repository at this point
Copy the full SHA cfd84d0View commit details -
Be more clear in places that mention(ed) "adjusted pressure state"
This reverts commit 19e894e ("data collection: Say adjusted pressure state calculation is implementation-defined"). "Adjusted pressure state"'s definition already says the algorithm is implementation-defined. While at it, also make the paragraph that says platform collectors should be able to connect to virtual pressure sources easier to understand: stop talking about adjusted pressure sources and just say "pressure sources", which is what the "adjusted pressure source" algorithm outputs.
Configuration menu - View commit details
-
Copy full SHA for b11010f - Browse repository at this point
Copy the full SHA b11010fView commit details
Commits on Jun 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 294ed01 - Browse repository at this point
Copy the full SHA 294ed01View commit details -
Improve handling of sample timestamps automation and non-automation c…
…ases With platform collectors now being per-global and per-source type, we need a way to clearly indicate that the "unprocessed" timestamp from a sample (i.e. what is fed to "relative high resolution time") must be the same across all globals. We also need to make sure that this works for both real and virtual pressure sources. - The abstract "pressure source" concept added a few commits ago now has an accompanying "pressure source sample" concept. It is a struct holding implementation-defined telemetry data as well as a timestamp corresponding to when it was obtained. Functionally, this should be identical to the what the spec has as of pull request w3c#280. - Virtual pressure source's "pending samples" is now a struct as well, holding similar data: a PressureState (like before) and a timestamp that is set to the "unshared current time" when the "update virtual pressure source" endpoint is called. - The "data collection" algorithm is responsible for reading either a "pressure source sample" or a virtual pressure source's "pending sample" and processing the timestamp value as necessary.
Configuration menu - View commit details
-
Copy full SHA for 9460e2c - Browse repository at this point
Copy the full SHA 9460e2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87ea0cf - Browse repository at this point
Copy the full SHA 87ea0cfView commit details
Commits on Jun 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b7f39a3 - Browse repository at this point
Copy the full SHA b7f39a3View commit details -
Unify "pressure source sample" and "pending sample descriptor" concepts
They were basically the same: a struct with data and a timestamp. In the "pending sample descriptor" case, the data was always a PressureState, whereas in the former's case it was an implementation-defined value. Since a virtual pressure source is a pressure source, we can say it also has an associated pressure source sample instance, so we can just use it and always set its data to a PressureState.
Configuration menu - View commit details
-
Copy full SHA for 1098cbb - Browse repository at this point
Copy the full SHA 1098cbbView commit details -
Do not surround null with
<code>
tagsThis was copied from the Generic Sensor spec and not done in other places, so drop the tag for uniformity.
Configuration menu - View commit details
-
Copy full SHA for e63d26b - Browse repository at this point
Copy the full SHA e63d26bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b98c68d - Browse repository at this point
Copy the full SHA b98c68dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a58799e - Browse repository at this point
Copy the full SHA a58799eView commit details -
automation: Check virtualPressureSourceType against "supported source…
… types" This ensures that the types accepted in automation are the same which are returned by `PressureObserver.knownSources`. Whether this is really desired can be worked out later.
Configuration menu - View commit details
-
Copy full SHA for 93beaa0 - Browse repository at this point
Copy the full SHA 93beaa0View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc3f3cd - Browse repository at this point
Copy the full SHA bc3f3cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32d3d9f - Browse repository at this point
Copy the full SHA 32d3d9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c966ff - Browse repository at this point
Copy the full SHA 5c966ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for a2cf3a4 - Browse repository at this point
Copy the full SHA a2cf3a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d11d169 - Browse repository at this point
Copy the full SHA d11d169View commit details
Commits on Jun 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aaf4da6 - Browse repository at this point
Copy the full SHA aaf4da6View commit details -
observe(): Do not always add a collector to the platform collector ma…
…pping Avoid adding a platform collector with an empty associated pressure source to the platform collector mapping. Having observe() attempt to find a suitable platform collector every time in this case is not that expensive, and _not_ doing it leads to a situation where inactive observers still need to call unobserve() or disconnect() to remove an entry from the platform collector mapping (to get observe() to try to connect to a platform collector again, for example).
Configuration menu - View commit details
-
Copy full SHA for 0e46949 - Browse repository at this point
Copy the full SHA 0e46949View commit details -
Configuration menu - View commit details
-
Copy full SHA for 094b061 - Browse repository at this point
Copy the full SHA 094b061View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16b08cd - Browse repository at this point
Copy the full SHA 16b08cdView commit details -
Make all WEBDRIVER2 citations normative
Usage so far had been inconsistent, with some places using the `!` syntax for normative references and others not doing so.
Configuration menu - View commit details
-
Copy full SHA for 93c8265 - Browse repository at this point
Copy the full SHA 93c8265View commit details