Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapping for nameless forms #97

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Add mapping for nameless forms #97

merged 1 commit into from
Nov 18, 2021

Conversation

carmacleod
Copy link
Contributor

@carmacleod carmacleod commented Nov 18, 2021

Adds a mapping for nameless forms.
Fixes #11.

Preview and Diff links not working - githack version


Preview | Diff

@joanmarie joanmarie self-requested a review November 18, 2021 12:30
Copy link
Contributor

@joanmarie joanmarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And Core-AAM isn't in CR yet. And I don't anticipate problems getting implementations. And there are three other positive reviews. So merging.

Thanks for the patch!

@jnurthen
Copy link
Member

@spectranaut are there implementations and tests for this?

@spectranaut
Copy link
Contributor

For tracking implementations: #11 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORE-AAM: Add conditional platform mappings for nameless forms
6 participants