-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-round-display][mediaquery] Properly define 'viewport-fit' #171
Comments
Thanks for this edit. To bring it fully in line with the resolution, I think you should make the following changes:
|
Also, the syntax in your examples is incorrect.
|
To answer your questions,
Not really. See the definition I propose above.
Let's say with have a round screen with a diameter of 200px. The size of the inscribed rectangle is diameter / sqrt(2) = 141 px.
You would use example 1 if you have content that takes into account rounded corners and has a layout that deals with very small sizes well. You would use example 2 if you have content that does not take into account rounded corners but has a layout that deals with very small sizes well. You would use example 3 if you have content that takes into account rounded corners but has a layout that does not deal well with small sizes of less than 400px. You would use example 4 if you have content that does not take into account rounded corners and has a layout that does not deal well with small sizes of less than 400px. The UA stylesheet of mobile browser typically contains |
That wording doesn't cut it, though I know what you mean. Current UAs don't do that. Content that is absolutely positioned far to the left or top, or with a huge negative indent or negative margin, or with a negative z-axis to put it under the canvas, or even with 'visibility: hidden' or 'display:none' can often not be viewed by the user (unless you count the inclusion of developer tools to change the CSS).. |
@bradkemper Good point: do you have a better wording? Something like "the UA must ensure that the entire layout viewport and any content overflowing it on the block-end and inline-end sides can be viewed [...]". That's not a terribly nice phrasing, but it is probably more correct. Do you have a better suggestion? |
|
Maybe something like this:
|
Defining this in terms of "what would be reachable / visible on a rectangular display" is probably the right way to deal with it: this is actually the intent, so why not spell it out, and it is a verifiable non-fuzzy claim (regardless of whether an automated testing setup is easy to put together). I am less sure about restricting it to “significant” content. While I agree that insignificant things, by definition, aren't important, agreeing on what's significant is trickier, and I think the fuzziness that this introduces in the definition will cause more problems than it solves. |
It seems like we need to allow some latitude for the UA to determine significance, or else we should define it. We shouldn't consider a UA as no conforming if it had 2mm corner rounding covering up some white background, for instance. The line between how much it can obscure or not should be defined either fuzzily or clearly. |
Those are really nice examples to understand how Also, I think it's better to change the definition of 'viewport-fit' from "set the size of the initial viewport" to "set the size of the visual viewport" if 'visual viewport' is defined in Device Adaptation Spec. |
Hi @jihyerish, sorry for the very late answer.
Yes
I don't think so. If you set the initial viewport, it will also indirectly set the visual viewport, but it will do more than that. Unless there is some other I realize that this would be a lot clearer if all these terms were properly defined, and that it is on me to go do that. I hope to be able to have time to do that soon, but so far I have not been able to prioritize it. Really sorry about that. |
This closes w3c#171. (This changset also fixes the content to work with the latest version of bikeshed which seems to have broken something when it comes to indenting code blocks.)
CC @frivoal
I modified the draft about 'viewport-fit' to apply the resolution we made at the SF f2f.
(Check the resolution in here)
I have some unclear things related to it:
@viewport (viewport-fit: cover) { ... }
@viewport (width: auto) { ... }
The text was updated successfully, but these errors were encountered: