-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-color-4] Add new set of CSS system colors (addresses #3804) #4091
Conversation
css-color-4/Overview.bs
Outdated
@@ -2332,6 +2332,56 @@ Converting Between Uncalibrated CMYK and RGB-Based Colors</h3> | |||
<li>fallback color must be set to the input color | |||
</ul> | |||
|
|||
|
|||
<h2 id="css-system-colors"> | |||
CSS System Colors</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned above, I think it would likely be better if something in this section included the deprecated system colors in the <system-color>
term so that other pieces of spec wouldn't miss half of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides removing the definition of <deprecated-system-color>
, would you mind clarifying what you'd like changed here? Move the deprecated list out of the appendix and into this section (though of course still noting they are deprecated)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbaron it looks like this PR is awaiting your clarification of what changes you requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional comments:
The security & privacy section needs updating, as we are re-introducing some of the fingerprinting potential of system colors. The introductory section on system colors should probably also explicitly call out this risk.
It would be helpful if new paragraph text could be re-structured to use semantic line breaks.
Also, Melanie, you might need to add yourself to the acknowledgements section!
A subsection makes sense. Or maybe the top-level section should be renamed "Color keywords", and then have four subsections below it:
|
22df596
to
0eda720
Compare
Commit has been updated to include the following changes:
|
Thanks for the fast updates, Melanie! On security & privacy, the issue is not just about spoofing, it's also about fingerprinting. See also #3873. |
0eda720
to
6a522b3
Compare
@AmeliaBR The security & privacy section of the spec already has a mention for the fingerprinting risk, do we feel it needs more detail? Seems like #3873 might be out of scope for this particular PR, or at least we might need to discuss first as a group? @Crissov @svgeesus was your upvote on Amelia's comment in favor of renaming the "Named colors" section to "Color keywords"? For now I had just moved system colors within the "Named colors" section. Thanks all for the feedback! |
I think your current text re security & privacy is accurate. Any discussion of stricter requirements on UAs can happen in the other issue. |
Iʼm I in the favor of renaming the section and adding sub-headings as suggested. |
Yes, it was. |
6a522b3
to
249aeb1
Compare
249aeb1
to
4fc9857
Compare
Just renamed "Named colors" section => "Color keywords" as requested (and sheepishly added myself to acknowledgements per @AmeliaBR's comment). Apologies for the intermittent delay on these last changes! |
Preserves language around system colors from css-color-3; moves undeprecated values from the appendix, leaving behind those which are still deprecated.