[selectors-4] Disallow nesting :has() inside :has(). #6952 #7344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byung-woo
force-pushed
the
disallow-nested-has
branch
from
7c398cc
to
842b6a9
Compare
byung-woo
force-pushed
the
disallow-nested-has
branch
from
842b6a9
to
8737a7e
Compare
|
@fantasai @tabatkins Could you ptal? I think this is the only thing blocking us from shipping :has() in Chrome. |
|
Thanks for the ping; I missed this over my vacation. |
|
Thanks for the ping and review! |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 21, 2022
The resolution of csswg issue #6952 has been applied: - w3c/csswg-drafts#7344 Bug: 1334631 Change-Id: Ied9c791aa729f9f1aeef02ddf9902c94736277b5
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 21, 2022
The resolution of csswg issue #6952 has been applied: - w3c/csswg-drafts#7344 Bug: 1334631 Change-Id: Ied9c791aa729f9f1aeef02ddf9902c94736277b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714637 Commit-Queue: Byungwoo Lee <blee@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1016121}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 21, 2022
The resolution of csswg issue #6952 has been applied: - w3c/csswg-drafts#7344 Bug: 1334631 Change-Id: Ied9c791aa729f9f1aeef02ddf9902c94736277b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714637 Commit-Queue: Byungwoo Lee <blee@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1016121}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 29, 2022
… nesting :has(), a=testonly Automatic update from web-platform-tests Remove 'tentative' from the wpt test for nesting :has() The resolution of csswg issue #6952 has been applied: - w3c/csswg-drafts#7344 Bug: 1334631 Change-Id: Ied9c791aa729f9f1aeef02ddf9902c94736277b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714637 Commit-Queue: Byungwoo Lee <blee@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1016121} -- wpt-commits: 825b8cfbf84c250bb351d2172525912d999677a4 wpt-pr: 34502
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jun 30, 2022
… nesting :has(), a=testonly Automatic update from web-platform-tests Remove 'tentative' from the wpt test for nesting :has() The resolution of csswg issue #6952 has been applied: - w3c/csswg-drafts#7344 Bug: 1334631 Change-Id: Ied9c791aa729f9f1aeef02ddf9902c94736277b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714637 Commit-Queue: Byungwoo Lee <blee@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1016121} -- wpt-commits: 825b8cfbf84c250bb351d2172525912d999677a4 wpt-pr: 34502
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
The resolution of csswg issue #6952 has been applied: - w3c/csswg-drafts#7344 Bug: 1334631 Change-Id: Ied9c791aa729f9f1aeef02ddf9902c94736277b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714637 Commit-Queue: Byungwoo Lee <blee@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1016121} NOKEYCHECK=True GitOrigin-RevId: 9dd78597a4663f81a0be36014b301fa738eccb73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple sentence to apply the resolution of issue #6952:
#6952 (comment)