Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-view-transitions-1] Clarify that observable image size refers to the border-box, and observed natural size is not affected by hw constraints #8819

Merged
merged 5 commits into from
May 11, 2023

Conversation

noamr
Copy link
Collaborator

@noamr noamr commented May 8, 2023

Ink-overflow is an implementation detail, and up to the UA to apply. object-view-box doesn't directly affect the ink-overflow rect. Replaced mentioned of ink-overflow rect with border box, and added note about how ink-overflow plays into this.

Also, texture size constraints should not affect the observed natural size of the captured image. Instead, implementations
should capture at least the visible part of the element (downscaled if they must).

See resolution 1 and resolution 2.

Closes #8561
Closes #8597

@jakearchibald
Copy link
Contributor

But the ink overflow does impact the texture size, so it does matter when the UA is looking to limit the texture size.

@noamr
Copy link
Collaborator Author

noamr commented May 8, 2023

But the ink overflow does impact the texture size, so it does matter when the UA is looking to limit the texture size.

It's true, I want to see what we come up with for #8561. I might wait to integrate a fix for #8561 first and then revise this.

@noamr
Copy link
Collaborator Author

noamr commented May 8, 2023

@jakearchibald ok clarified it for now, and will revise the whole thing about texture sizes with #8561.

@noamr
Copy link
Collaborator Author

noamr commented May 8, 2023

Reading both #8561 and #8597, I see both ink-overflow and max-texture-size as implementation-defined things that shouldn't be web observable. So we'll have some notes that ink-overflow is applied to the canvas and some big elements might not be rendered as expected due to hardware constraints, but otherwise all of this is an implementation thing.

This is not different from regular CSS transforms and accelerated compositing, where sometimes you have tiling artifacts or run out of texture memory. We can also treat those as bugs, and incrementally try our best to show something legible (e.g. a blurry scaled-down version of the texture, or use tiling) and vendors can differentiate on this if they want.

@noamr noamr requested review from khushalsagar and bokand May 9, 2023 12:53
css-view-transitions-1/Overview.bs Outdated Show resolved Hide resolved
css-view-transitions-1/Overview.bs Outdated Show resolved Hide resolved
css-view-transitions-1/Overview.bs Outdated Show resolved Hide resolved
css-view-transitions-1/Overview.bs Outdated Show resolved Hide resolved
css-view-transitions-1/Overview.bs Outdated Show resolved Hide resolved
noamr added 5 commits May 11, 2023 21:02
Ink-overflow is an implementation detail, and up to the UA
to apply. object-view-box doesn't directly affect the ink-overflow rect.

See [resolution](w3c#8597 (comment)).

Closes w3c#8597
@noamr noamr changed the title [css-view-transitions-1] Clarify that observable image size refers to the border-box [css-view-transitions-1] Clarify that observable image size refers to the border-box, and observed natural size is not affected by hw constraints May 11, 2023
@khushalsagar khushalsagar merged commit bea2984 into w3c:main May 11, 2023
fantasai added a commit to fantasai/csswg-drafts that referenced this pull request Aug 2, 2023
…ge content box w3c#8819

And not e.g. squashed into it.

See w3c#8819 for discussions
khushalsagar pushed a commit that referenced this pull request Aug 2, 2023
…ge content box #8819 (#9137)

And not e.g. squashed into it.

See #8819 for discussions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants