Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Changes section #125

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Add Changes section #125

merged 3 commits into from
Dec 11, 2023

Conversation

anssiko
Copy link
Member

@anssiko anssiko commented Dec 5, 2023

This section summarizes substantial changes and notable editorial improvements to guide review.


Preview | Diff

This section summarizes substantial changes and notable editorial
improvements to guide review.
Copy link
Member

@reillyeon reillyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with editorial nits

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
- Make security and privacy considerations normative
- Add the ondeviceorientationabsolute event handler attribute into the IDL block (was only in prose)
- Remove '?' from dictionary members of DeviceMotionEventInit
- Use [Exposed=Window] extended attribute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Use [Exposed=Window] extended attribute
- Use [Exposed=Window] extended attribute

anssiko and others added 2 commits December 11, 2023 14:48
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
@anssiko
Copy link
Member Author

anssiko commented Dec 11, 2023

Thanks @reillyeon. Knowing @rakuco is transitioning into a well-deserved vacation mode, I will bravely merge this to make his review backlog a tad shorter when he returns. Any substantive changes added should be reflected to this section to aid reviewers.

@anssiko anssiko merged commit 63c9356 into main Dec 11, 2023
2 checks passed
github-actions bot added a commit that referenced this pull request Dec 11, 2023
SHA: 63c9356
Reason: push, by anssiko

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants