-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Changes section #125
Add Changes section #125
Conversation
This section summarizes substantial changes and notable editorial improvements to guide review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with editorial nits
- Make security and privacy considerations normative | ||
- Add the ondeviceorientationabsolute event handler attribute into the IDL block (was only in prose) | ||
- Remove '?' from dictionary members of DeviceMotionEventInit | ||
- Use [Exposed=Window] extended attribute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Use [Exposed=Window] extended attribute | |
- Use [Exposed=Window] extended attribute | |
Thanks @reillyeon. Knowing @rakuco is transitioning into a well-deserved vacation mode, I will bravely merge this to make his review backlog a tad shorter when he returns. Any substantive changes added should be reflected to this section to aid reviewers. |
SHA: 63c9356 Reason: push, by anssiko Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This section summarizes substantial changes and notable editorial improvements to guide review.
Preview | Diff