Restructure Core Properties section #345
Conversation
rhiaro
requested review from
msporny,
dlongley,
peacekeeper,
OR13 and
kdenhartog
|
There are still merge conflicts here, waiting for those to be resolved. |
Identifiers section contains no normative language, defines no core properties, and adds nothing that isn't covered elsewhere in the spec.
Superceded by verificationMethod. Text from the Public Key section has been adapted (where necessary) and integrated into the Verification Methods section.
Rename from Authorization and Delegation to Control. Move text concerning DID methods to the DID methods section.
rhiaro
force-pushed
the
rhiaro-restructure-core-properties
branch
from
a807e46
to
1396daa
Compare
rhiaro
force-pushed
the
rhiaro-restructure-core-properties
branch
from
1396daa
to
38c28cd
Compare
There was a problem hiding this comment.
Largely editorial, I believe the shuffling of the normative text still reflects the consensus position of the group (which is subject to change in the following weeks, maybe). Given the size of the PR, we should merge it in quickly so that we can rebase others that have been waiting on this one to go in.
LGTM.
|
Need a review as quickly as you can get to it, please -- @dlongley @OR13 @kdenhartog @peacekeeper. |
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
| </li> | ||
| <li> | ||
| not use the <a>DID Document</a> at all to decide this, but have rules that are | ||
| "built into" the method. | ||
| </li> | ||
| </ul> | ||
|
|
||
| <p> | ||
| Each <a>DID method</a> MUST define how authorization is implemented, including |
There was a problem hiding this comment.
Suggest more precise language here:
MUST define how authorization of operations performed on DID Document is implemented
Partially resolves #363
There was a problem hiding this comment.
Thanks @Fak3, could you note that proposed change in the related issue if not already? I'd like to note that this PR only moves text around and does not change anything (except to consolidate given new structure). Proposes for changes to text affected by this PR should be made in related issues or new PRs once this is merged.
|
Multiple reviews, changes requested and made, no objections, largely editorial, merging. |
Adjusts the nesting a bit and some of the subheadings for readability.
Adds a mini TOC to the beginning so that people looking for actual property names can find them quickly (as it's not always obvious from the subheadings in the actual TOC).
Adds
dfnelements to all the properties, and corresponding internal refs. Also includes some CSS so links in code elements keep the same appearance.Removes the
publicKeyproperty, and integrates remaining text into the Verification Methods section. Adds a subsection for key types and formats. I'd appreciate careful review of this in particular to make sure I didn't mix up wording around keys vs verification methods. I also add explicit values fortypefor each of the keys (where known; one is missing). I'm aware that support for some of these key types is still up for discussion, I just kept the list the same for now. Altering what appears in the table should be orthogonal.There's a bit from the old Public Key section about embedding vs referencing public keys, with a little algorithm about how to find the key data in a DID doc. I updated to the language for this to apply to verification methods rather than only public keys. But I'm not sure if this is accurate. Possibly this whole bit is outdated and ought to be removed - advice appreciated.
Replaces
publicKeywithverificationMethodin all examples that use it.Preview | Diff