Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use publicKeyMultibase instead of publicKeyBase58 field in all examples #852

Closed
wants to merge 1 commit into from

Conversation

Patrik-Stas
Copy link

@Patrik-Stas Patrik-Stas commented Mar 21, 2024

Hi, I believe that some examples were by mistake using publicKeyBase58 rather than publicKeyMultibase - I've updated the examples. Let me know if I am missing something.

Cheers


Preview | Diff

Signed-off-by: Patrik Stas <patrik.stas@gmail.com>
@msporny msporny added editorial Editors should update the spec then close class 2 Changes that do not functionally affect interpretation of the document labels Jul 1, 2024
@msporny
Copy link
Member

msporny commented Jul 7, 2024

The examples use Ed25519VerificationKey2018, which only supported publicKeyBase58. We do plan to update the examples to use more modern key formats such as Multikey, which does use publicKeyMultibase.

@msporny msporny closed this Jul 7, 2024
@msporny
Copy link
Member

msporny commented Jul 7, 2024

@Patrik-Stas could you please update the PR to use Multikey, you can find the format description here:

https://w3c.github.io/controller-document/#multikey

@msporny msporny reopened this Jul 7, 2024
@decentralgabe
Copy link
Contributor

Related to the context discussion on today's call. Suggestion is to pull in the new multikey context.

@msporny msporny self-assigned this Aug 15, 2024
@w3cbot
Copy link

w3cbot commented Aug 15, 2024

iherman marked as non substantive for IPR from ash-nazg.

Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust the multibase values are correct...

@pchampin
Copy link
Contributor

This was discussed during the WG meeting on 2024-08-22:
https://www.w3.org/2024/08/22-did-minutes.html#t06

@msporny
Copy link
Member

msporny commented Sep 19, 2024

Since we haven't heard back from the original author yet, I'll effect these changes on the core specification.

@pchampin
Copy link
Contributor

This was discussed during the #did meeting on 19 September 2024.

View the transcript

w3c/did-core#852

manu: This one is waiting on merge conflict resolution
… We might have to do a more complete fix with this one. Or pull the PR in and make the fix later

decentralgabe: I noticed you tagged the author. If manu you can take it over that would be great

manu: Sure, I can take it over.

ivan: Why do you think it is aclass 2 change? I think it is a class 3
… using public key multibase effects implementations

manu: It effects the examples, this is non-normative

ivan: Okay, yep its a class 2

manu: There is a separate issue that discusses upgrading to publicKeyMultibase

https://github.com/w3c/did-core/issues


@msporny
Copy link
Member

msporny commented Oct 30, 2024

This PR has been merged into PR #867. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class 2 Changes that do not functionally affect interpretation of the document editorial Editors should update the spec then close
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants