-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use publicKeyMultibase
instead of publicKeyBase58
field in all examples
#852
Conversation
Signed-off-by: Patrik Stas <patrik.stas@gmail.com>
The examples use |
@Patrik-Stas could you please update the PR to use |
Related to the context discussion on today's call. Suggestion is to pull in the new multikey context. |
iherman marked as non substantive for IPR from ash-nazg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust the multibase values are correct...
This was discussed during the WG meeting on 2024-08-22: |
Since we haven't heard back from the original author yet, I'll effect these changes on the core specification. |
This was discussed during the #did meeting on 19 September 2024. View the transcriptw3c/did-core#852manu: This one is waiting on merge conflict resolution decentralgabe: I noticed you tagged the author. If manu you can take it over that would be great manu: Sure, I can take it over. ivan: Why do you think it is aclass 2 change? I think it is a class 3 manu: It effects the examples, this is non-normative ivan: Okay, yep its a class 2 manu: There is a separate issue that discusses upgrading to publicKeyMultibase https://github.com/w3c/did-core/issues |
This PR has been merged into PR #867. Closing. |
Hi, I believe that some examples were by mistake using
publicKeyBase58
rather thanpublicKeyMultibase
- I've updated the examples. Let me know if I am missing something.Cheers
Preview | Diff