Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow CSS custom properties with no value #1581

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

rdeltour
Copy link
Member

Fix the built-in CSS parser to allow custom properties with empty values, as this is valid CSS.
See https://www.w3.org/TR/css-variables/#guaranteed-invalid

Fixes #1538

Fix the built-in CSS parser to allow custom properties with empty values,
as this is valid CSS.
See https://www.w3.org/TR/css-variables/#guaranteed-invalid

Fixes #1538
@rdeltour rdeltour added the status: ready to merge The pull request is ready to be merged label Dec 23, 2024
@rdeltour rdeltour added this to the Next maintenance release milestone Dec 23, 2024
@rdeltour rdeltour self-assigned this Dec 23, 2024
Base automatically changed from fix/1548/invalid-utf8-sequence to main December 29, 2024 00:00
@rdeltour rdeltour merged commit d60da30 into main Dec 29, 2024
5 checks passed
@rdeltour rdeltour deleted the fix/1538/css-custom-prop branch December 29, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready to merge The pull request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty CSS custom values generate an error
1 participant