Make sure tests reset the default locale #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests were setting the default Locale, but were not setting it back to the original value. This side effect caused later localization tests to fail. This PR fixes that by making sure the default locale is reset, in a `finally` block, whenever it is explicitly set in tests. Fixes #916
tofi86
approved these changes
Nov 27, 2018
|
Looks good to me. Would have taken me a while to find this out. I was still hanging on the weird Go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were setting the default Locale, but were not setting it back to the original value. This side effect caused later localization tests to fail.
This PR fixes that by making sure the default locale is reset, in a
finallyblock, whenever it is explicitly set in tests.Fixes #916