remove default locale setting in pom.xml #931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set locale as English per methods/classes if needed.
rdeltour
added
the
status: needs review
rdeltour
approved these changes
Jan 17, 2019
There was a problem hiding this comment.
Looks generally good to me. I'm modifying the proposed change to set/reset the default locale in before/after methods however, in order to not rely on the Report#setLocale EPUBCheck API for the tests that don't otherwise depend on it.
Many thanks for the contrib @takahashim! 👍
rdeltour
added
status: completed
|
Merged as 2d5dbea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #919.
set locale as English per methods/classes if needed.
I've tested in my environments:
ja_JP.