fix: switch item property doesn't apply to svg:switch
#944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeltour
added
status: needs review
mattgarrish
reviewed
Jan 17, 2019
The `switch` property of Package Documents `item` elements indicates that the described Publication Resource contains one or more instances of the `epub:switch` element. It should not be declared when the EPUB contains SVG using the `svg:switch` element. Fixes #857
rdeltour
force-pushed
the
fix/issue-857
branch
from
849b4b4 to
91b84ad
Compare
|
@mattgarrish should be fixed now 🙂 |
mattgarrish
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
switchproperty of Package Documentsitemelements indicatesthat the described Publication Resource contains one or more instances
of the
epub:switchelement. It should not be declared when the EPUBcontains SVG using the
svg:switchelement.Fixes #857