Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Kill DOMRectList" #186

Merged
merged 3 commits into from
Aug 3, 2017
Merged

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Jun 5, 2017

@foolip
Copy link
Member

foolip commented Jun 30, 2017

Is this blocked only on review? @fserb FYI

@fserb
Copy link
Member

fserb commented Jul 6, 2017

Friendly ping on this. I've just updated Chrome Canary to this, so it would be nice to have a response on it soon.

@syncbot syncbot force-pushed the zcorpan/revert-kill-domrectlist branch from faf546f to bc1340a Compare August 1, 2017 14:17
@jpmedley
Copy link

jpmedley commented Aug 2, 2017

Pinging on this again. I need to mention @fserb 's update in a blog post about Chrome 61. I'm blocked if this hasn't landed.

@foolip
Copy link
Member

foolip commented Aug 3, 2017

I'm pretty sure @zcorpan isn't working this week. Who else has the power to merge things in this repo?

@foolip
Copy link
Member

foolip commented Aug 3, 2017

The most recent commit in the directory by anyone other than @zcorpan is 760283d. @tabatkins, if this is reviewed, can you merge it?


<pre class=idl>
[NoInterfaceObject,
ArrayClass]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be [LegacyArrayClass] per https://heycam.github.io/webidl/#LegacyArrayClass.

Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit.

@tabatkins tabatkins merged commit 7e6d9c2 into master Aug 3, 2017
@tabatkins
Copy link
Member

Done 👍

@foolip
Copy link
Member

foolip commented Aug 3, 2017

Thanks!

@zcorpan zcorpan deleted the zcorpan/revert-kill-domrectlist branch August 14, 2017 10:46
@syncbot syncbot restored the zcorpan/revert-kill-domrectlist branch August 18, 2017 21:32
@plinss plinss deleted the zcorpan/revert-kill-domrectlist branch August 18, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants