Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with DOM's abort reason #53

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Conversation

nidhijaju
Copy link
Member

@nidhijaju nidhijaju commented Mar 15, 2022

whatwg/dom#1027 removed the "aborted flag" from DOM's AbortSignal.
This change updates the Geolocation Sensor spec with the aborted predicate and rejecting promises with the signal's abort reason, instead of with a new "AbortError" DOMException.


Preview | Diff

@anssiko
Copy link
Member

anssiko commented Mar 15, 2022

Thanks for this contribution!

@reillyeon can you confirm @nidhijaju’s affiliation so we can clear the ipr check.

@reillyeon
Copy link
Member

@nidhijaju, can you visit https://www.w3.org/users/myprofile/connectedaccounts to link your GitHub account with your W3C account so the IPR checks know who you are?

@nidhijaju
Copy link
Member Author

Yes, I've just linked my Github account to my W3C account. Hopefully this solves the issue.

@reillyeon reillyeon merged commit 56efb87 into w3c:main Mar 16, 2022
@nidhijaju nidhijaju deleted the update-abortreason branch March 16, 2022 00:18
github-actions bot added a commit that referenced this pull request Mar 16, 2022
SHA: 56efb87
Reason: push, by @reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@anssiko
Copy link
Member

anssiko commented Mar 16, 2022

Thanks @nidhijaju @reillyeon!

@nidhijaju if you are interested in contributing to the WG’s specs more frequently, I’d encourage you to join: https://www.w3.org/das/participate

(The ipr check passes automatically for WG participants.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants