Modernize Gyroscope constructor steps #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt to Web IDL's current practices and be less hand-wavy when constructing a Gyroscope instance: - We are given `this` so we do not need to say "let foo be a new instance of IDLInterface". - Similarly, there is no need to return anything from the "construct a gyroscope object" operation, it is only supposed to either initialize `this` or throw an exception. - Pass the right argument with the right type to "check sensor policy-controlled features".
reillyeon
approved these changes
Oct 24, 2023
anssiko
approved these changes
Oct 25, 2023
github-actions bot
added a commit
that referenced
this pull request
Oct 25, 2023
SHA: 1aa906b Reason: push, by anssiko Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to Web IDL's current practices and be less hand-wavy when constructing
a Gyroscope instance:
thisso we do not need to say "let foo be a new instance ofIDLInterface".
gyroscope object" operation, it is only supposed to either initialize
thisor throw an exception.policy-controlled features".
Preview | Diff