Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow aria-hidden on body element #447

Merged
merged 5 commits into from
Mar 6, 2023
Merged

Commits on Mar 3, 2023

  1. disallow aria-hidden on body element

    related to w3c/aria#1254
    
    closes #221 - there were comments to do more with aria-hidden rules beyond just disallowing it on body, but i'm going to make a new issue for potentially covering those topics.
    scottaohara committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    c4e8c2c View commit details
    Browse the repository at this point in the history
  2. clarify rule

    as `aria-hidden=false` doesn't seem to cause any problems, even per the note in ARIA to use with caution:
    >At the time of this writing, aria-hidden="false" is known to work inconsistently in browsers. As future implementations improve, use caution and test thoroughly before relying on this approach.
    
    let's limit this rule to just `aria-hidden=true`
    scottaohara committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    f354341 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Configuration menu
    Copy the full SHA
    cda2ab4 View commit details
    Browse the repository at this point in the history
  2. changelog update

    scottaohara committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    08a3eac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9b00091 View commit details
    Browse the repository at this point in the history