-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe lists containing lists, as motivated by GeoJSON. #41
Conversation
I do not have a real issue with the changes, so we can merge it; my comments are purely of an editorial nature and reflect a matter of taste... Take them as you wish, salt 'n pepper them at taste...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See
#41 (comment)
They are both about arrays and ordering, which is why they were together. We do need to do a comprehensive reorganization, but I'd rather not do that on a piecemeal basis.
Noted.
Indeed, but this is a somewhat daunting task, for which I could use some help. In particular, we probably need to use something like jsonld-vis to simplify creating such graphs, although this may prove to be a problem for non-HTML use. |
…sts in expanded form.
Hey @gkellogg
I was not clear, sorry about that. I meant deeper subsections within this subsection. But I agree that this can wait, subject to a reorganization
It is complicated indeed. The table/expanded/TriG/n-quads versions may not be that bad just lot of writing; if the graphs prove to be too much work, we can drop that one. (B.t.w., for some reasons, example 57 does not appear in the preview. I presume it will be there for the merged version.) |
+1 to reorganization, and +1 to not doing it as part of this PR :) |
I'd like to handle this PR and w3c/json-ld-api#16, which ideally could use an implementation, but should at least have a review. |
I already pinged Axel and I'll give it a read tmrw! |
index.html
Outdated
</pre> | ||
|
||
<p class="changed">In JSON-LD 1.1, lists of lists, where the value of | ||
a <a>list object</a>, may itself be a <a>list object</a> recusively, are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/recusively// (I don't think we need to say that)
index.html
Outdated
a <a>list object</a>, may itself be a <a>list object</a> recusively, are | ||
fully supported. For example, in <em>GeoJSON</em> (see [[RFC7946]]), | ||
<em>coordinates</em> are an ordered list of <em>positions</em>, which are | ||
represented as an array of two or more numbers. For example:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/numbers. For example:/numbers:/
index.html
Outdated
} | ||
</pre> | ||
|
||
<p class="changed">For this example, it's important that the values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
For this example,
only for this example or all uses of coordinates?
-
s/the values/values/
index.html
Outdated
</pre> | ||
|
||
<p class="changed">For this example, it's important that the values | ||
expressed within coordinates maintain their order, which requires the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/coordinates/coordinates/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added minor comments inline
@sgillies as the primary author of GeoJSON-LD your thoughts on this would be most appreciated! |
[-10.0, -10.0], | ||
[10.0, -10.0], | ||
[10.0, 10.0], | ||
[-10.0, -10.0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that GeoJSON examples can be made less confusing with respect to longitude, latitude ordering by using real-world coordinates like [-105.615115, 40.255014]
(latitude: 40.255 degrees N, longitude: 105.615 degrees W).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the lists of lists feature does not preclude #34, although it becomes less important, and it does add significantly more complexity to the processing model.
"@vocab": "https://purl.org/geojson/vocab#", | ||
"type": "@type", | ||
"bbox": {"@container": "@list"}, | ||
"coordinates": {"@container": "@list"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In geojson/geojson-ld#34 we discussed an @ndarray
, but @list
looks just as good, or better in that it's easier to explain and understand.
{"@list": [{"@value": -10.0}, {"@value": -10.0}]}, | ||
{"@list": [{"@value": 10.0}, {"@value": -10.0}]}, | ||
{"@list": [{"@value": 10.0}, {"@value": 10.0}]}, | ||
{"@list": [{"@value": -10.0}, {"@value": -10.0}]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine. Tagential question: is there a way to indicate to JSON-LD users that the first element of these 2-tuples is longitude and the second is latitude?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really. If the vocabulary were modeled in OWL, there may be some way to do this at that level, @iherman may know better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, even in OWL I don't see a way to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a graph modeling perspective, the fact that the lat/long were originally presented in a list isn't important, is it? Only the "outer" list of coordinates has value to the graph (afaict).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #36.
This is implemented in w3c/json-ld-api#16.
Preview | Diff