Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate member names with SW #542

Closed
anssiko opened this issue Jan 23, 2017 · 1 comment
Closed

Duplicate member names with SW #542

anssiko opened this issue Jan 23, 2017 · 1 comment

Comments

@anssiko
Copy link
Member

anssiko commented Jan 23, 2017

We have some duplicate definitions:

Duplicate definition of 'scope member'
Duplicate definition of 'src member'
Duplicate definition of 'type member'

To address these dupes, after discussing with @kenchris, I'd suggest we rename the SW-specific concepts uniquely since they're not the same as the ones initially defined in the manifest spec. We can keep the JSON property names intact if needed for compatibility with shipping implementations.

This is how the members defined in the manifest map to the corresponding SW spec definitions:

scope -> https://w3c.github.io/ServiceWorker/#dfn-scope-url
src -> https://w3c.github.io/ServiceWorker/#dfn-job-script-url
type -> https://w3c.github.io/ServiceWorker/#dfn-job-worker-type

This is where the mapping should happen: https://w3c.github.io/manifest/#dfn-steps-for-processing-the-serviceworker-member

This was referenced Jan 23, 2017
@anssiko
Copy link
Member Author

anssiko commented Jan 31, 2017

@marcoscaceres fixed this with 83bfb5b

Thanks!

@anssiko anssiko closed this as completed Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant