Fix ReSpec warnings #543
Merged
Fix ReSpec warnings #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenchris
reviewed
Jan 23, 2017
| @@ -602,7 +602,7 @@ <h3 id="installation-sec"> | |||
| <li>Otherwise, return <code>false</code>. | |||
| </li> | |||
| </ol> | |||
| <div class="issue" title="🐒 Monkey patch"> | |||
| <div class="issue" title="🐒 Monkey patch"> | |||
There was a problem hiding this comment.
You changed that in other patch... better remove from that commit?
There was a problem hiding this comment.
TL;DR: TextMate does not like unicode monkey.
|
Thanks! (Every time I touch this spec, the monkey keeps reminding me I should move on from TextMate. But I'm hooked.) |
|
@anssiko, I know and understand. Don't worry :) I got my own software-drug problems (e.g., AirMail... it's a pile a garbage, but I. Can't. Break. Free.... an ReSpec... I. Love. Hacking. On. It. Send! Help!). |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReSpec now surfaces the warnings and errors more prominently (thanks @marcoscaceres!), so I started looking at fixing those for this spec.
I was able to get rid of the warnings, together with changes in #520 those are gone.
However, fixing errors requires more substantive change, opened #542 for that.