Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supportedEntryTypes: should show types rather than names #48

Closed
noamr opened this issue Feb 27, 2020 · 0 comments · Fixed by #49
Closed

supportedEntryTypes: should show types rather than names #48

noamr opened this issue Feb 27, 2020 · 0 comments · Fixed by #49
Assignees
@npm1

Comments

@noamr
Copy link
Contributor

noamr commented Feb 27, 2020

From the spec:
NOTE: A user agent implementing PerformancePaintTiming would need to include "first-paint" and "first-contentful-paint" in supportedEntryTypes for Window contexts. This allows developers to detect support for paint timing.

I believe it should be:
NOTE: A user agent implementing PerformancePaintTiming would need to include "paint" in supportedEntryTypes for Window contexts. This allows developers to detect support for paint timing.
@npm1
Copy link
Contributor

npm1 commented Feb 27, 2020

Yea, you're right! This needs to be changed in spec only. The WPT is correctly using 'paint'.

npm1 added a commit that referenced this issue Feb 27, 2020
@npm1
Fix Note about supportedEntryTypes
4bcae73 
Fixes #48. The type introduced in this spec is just 'paint'.
@npm1 npm1 mentioned this issue Feb 27, 2020
Merged
@npm1 npm1 closed this as completed in #49 Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@npm1 npm1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Note about supportedEntryTypes w3c/paint-timing
2 participants
@noamr @npm1