Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TAO check from element timing & LCP reporting #105

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Nov 4, 2024

The TAO check does not add any security measure, given rendering same-origin and cross-origin images in the same frame would result in the same renderTime.

Closes #104


Preview | Diff

The TAO check does not add any security measure, given rendering same-origin and
cross-origin images in the same frame would result in the same renderTime.

Closes #104
@noamr noamr requested a review from clelland November 4, 2024 17:44
Copy link
Contributor

@clelland clelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'd just include in the title that it also covers LCP, since ET and LCP are independent of each other now.

@noamr noamr changed the title Remove TAO check from element timing reporting Remove TAO check from element timing & LCP reporting Nov 4, 2024
@noamr noamr merged commit 486220f into main Nov 4, 2024
2 checks passed
@noamr noamr deleted the render-time branch November 4, 2024 17:53
github-actions bot added a commit that referenced this pull request Nov 4, 2024
SHA: 486220f
Reason: push, by noamr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider to expose decoding time for FCP and LCP?
2 participants