Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to viewport #65

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Add link to viewport #65

merged 1 commit into from
Mar 6, 2020

Conversation

npm1
Copy link
Contributor

@npm1 npm1 commented Mar 6, 2020 •
edited by pr-preview bot
Loading

A request was made to add a link to the viewport.
Fixes #58

Preview | Diff

@npm1
Add link to viewport
9270454 
A request was made to add a link to the viewport.
Fixes #58
@npm1 npm1 requested review from rniwa and yoavweiss March 6, 2020 19:00
yoavweiss
yoavweiss approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoavweiss yoavweiss merged commit a3113c3 into master Mar 6, 2020
@npm1 npm1 deleted the viewport branch March 6, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoavweiss yoavweiss yoavweiss approved these changes

@rniwa rniwa Awaiting requested review from rniwa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify whether First Contentful Paint considers content outside the viewport
2 participants
@npm1 @yoavweiss