A PaymentItem can't be a "valid decimal monetary value"
#334
Comments
domenic
added a commit
to domenic/browser-payment-api
that referenced
this issue
Dec 13, 2016
- Fixes w3c#373: align ordering of steps with Blink's implementation, except check for allowed-to-use first since that makes more sense - Fixes w3c#334: properly get the total.amount.value instead of pretending total is a string - Fixes w3c#335: do not assume additionalDisplayItems is present - Fixes part of w3c#321: use proper dictionary terminology - Ensures request.[[details]].shippingOptions/modifiers is always a sequence, instead of sometimes left as not present - Fixes various algorithm structure and typographic issues
domenic
added a commit
to domenic/browser-payment-api
that referenced
this issue
Dec 13, 2016
- Fixes w3c#373: align ordering of steps with Blink's implementation, except check for allowed-to-use first since that makes more sense - Fixes w3c#334: properly get the total.amount.value instead of pretending total is a string - Fixes w3c#335: do not assume additionalDisplayItems is present - Fixes part of w3c#321: use proper dictionary terminology - Ensures request.[[details]].shippingOptions/modifiers is always a sequence, instead of sometimes left as not present - Fixes various algorithm structure and typographic issues
domenic
added a commit
to domenic/browser-payment-api
that referenced
this issue
Dec 13, 2016
- Fixes w3c#373: align ordering of steps with Blink's implementation, except check for allowed-to-use first since that makes more sense - Fixes w3c#334: properly get the total.amount.value instead of pretending total is a string - Fixes w3c#333 and fixes w3c#335: do not assume various dictionaries are present - Fixes part of w3c#321: use proper dictionary terminology - Ensures request.[[details]].shippingOptions/modifiers is always a sequence, instead of sometimes left as not present - Fixes various algorithm structure and typographic issues
domenic
added a commit
to domenic/browser-payment-api
that referenced
this issue
Dec 23, 2016
- Fixes w3c#373: align ordering of steps with Blink's implementation, except check for allowed-to-use first since that makes more sense - Fixes w3c#334: properly get the total.amount.value instead of pretending total is a string - Fixes w3c#333 and fixes w3c#335: do not assume various dictionaries are present - Fixes part of w3c#321: use proper dictionary terminology - Ensures request.[[details]].shippingOptions/modifiers is always a sequence, instead of sometimes left as not present - Fixes various algorithm structure and typographic issues
marcoscaceres
pushed a commit
that referenced
this issue
Jan 4, 2017
- Fixes #373: align ordering of steps with Blink's implementation, except check for allowed-to-use first since that makes more sense - Fixes #334: properly get the total.amount.value instead of pretending total is a string - Fixes #333 and fixes #335: do not assume various dictionaries are present - Fixes part of #321: use proper dictionary terminology - Ensures request.[[details]].shippingOptions/modifiers is always a sequence, instead of sometimes left as not present - Fixes various algorithm structure and typographic issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Step 11 of https://w3c.github.io/browser-payment-api/#constructor says:
But the "total" member of
PaymentDetailsModifieris aPaymentItem, not a string. So checking whether it's a "valid decimal monetary value" is nonsensical.The text was updated successfully, but these errors were encountered: