Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please define your internal slot notation before using it #336

Closed
bzbarsky opened this issue Nov 30, 2016 · 1 comment
Closed

Please define your internal slot notation before using it #336

bzbarsky opened this issue Nov 30, 2016 · 1 comment

Comments

@bzbarsky
Copy link

https://w3c.github.io/browser-payment-api/#constructor step 15 says:

Store methodData into request@[[methodData]].

I assume this means "store methodData into the internal slot of request that is named [[methodData]]". But nothing in this document (certainly nothing before this point) actually defines that that's what the '@' notation means.

@bzbarsky
Copy link
Author

Ah, I see, it's hiding all the way in the end in section 18. This sort of definition should be at the beginning of the document, or the '@' needs to link to its definition. Or both.

domenic added a commit to domenic/browser-payment-api that referenced this issue Dec 13, 2016
Fixes w3c#336. See the history here in whatwg/streams#178tc39/ecma262#574tc39/ecma262#591whatwg/streams@7791c58. My bad for leading people down this path.
domenic added a commit to domenic/browser-payment-api that referenced this issue Dec 13, 2016
Fixes w3c#336. See the history here in whatwg/streams#178tc39/ecma262#574tc39/ecma262#591whatwg/streams@7791c58. My bad for leading people down this path.
marcoscaceres pushed a commit that referenced this issue Dec 13, 2016
Fixes #336. See the history here in whatwg/streams#178tc39/ecma262#574tc39/ecma262#591whatwg/streams@7791c58. My bad for leading people down this path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant