Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor typographical fixes #368

Merged
merged 1 commit into from
Dec 13, 2016
Merged

Minor typographical fixes #368

merged 1 commit into from
Dec 13, 2016

Conversation

domenic
Copy link
Collaborator

@domenic domenic commented Dec 13, 2016

  • Fix "store" value in [[internalSlot]]  #353: set slots to values, don't store in slots
  • Use <var> instead of <em> for variables
  • Use <i> instead of <em> for state names
  • Don't use <em> or <code> for literal values like null, undefined, false, and true.
  • Run HTML Tidy

- Fix w3c#353: set slots to values, don't store in slots
- Use <var> instead of <em> for variables
- Use <i> instead of <em> for state names
- Don't use <em> or <code> for literal values like null, undefined, false, and true.
- Run HTML Tidy
@marcoscaceres
Copy link
Member

Looks good! thanks @domenic.

@marcoscaceres marcoscaceres removed their request for review December 13, 2016 20:11
@marcoscaceres
Copy link
Member

D'oh, I'd assume this was the first part - as it come in first.

@domenic
Copy link
Collaborator Author

domenic commented Dec 13, 2016

This one first is good! I've rebased #369 and #370, although for some reason #370 is still showing merge conflicts.

@marcoscaceres
Copy link
Member

Yeah, #370 confused me. Cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants