Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added based on issue 936 #937

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Added based on issue 936 #937

merged 2 commits into from
Feb 4, 2021

Conversation

ianbjacobs
Copy link
Collaborator

@ianbjacobs ianbjacobs commented Jan 26, 2021

#936 (comment)

closes #936

The following tasks have been completed:

  • Confirmed there are no ReSpec errors/warnings.
  • Modified Web platform tests (link)
  • Modified MDN Docs (link)
  • Has undergone security/privacy review (link)

Implementation commitment:

  • Safari (link to issue)
  • Chrome (link to issue)
  • Firefox (link to issue)
  • Edge (public signal)

Impact on Payment Handler spec: Requires payment apps to ensure adequate user consent mechanisms.


Preview | Diff

index.html Outdated
Comment on lines 4904 to 4913
In particular, the {{PaymentMethodData.data}} and
{{PaymentResponse.details}} members allow for the arbitrary exchange
of data. In light of the wide range of data models used by existing
payment methods, prescribing data specifics in this API would limit
its usefulness. The {{PaymentResponse.details}} member carries data
from the payment handler, whether Web-based (as defined by the
[[Payment Handler API]]) or proprietary. The <a>user agent</a> MUST
NOT support payment handlers unless they include adequate user
consent mechanisms (such as awareness of parties to the transaction
and mechanisms for demonstrating the intention to share data).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In particular, the {{PaymentMethodData.data}} and
{{PaymentResponse.details}} members allow for the arbitrary exchange
of data. In light of the wide range of data models used by existing
payment methods, prescribing data specifics in this API would limit
its usefulness. The {{PaymentResponse.details}} member carries data
from the payment handler, whether Web-based (as defined by the
[[Payment Handler API]]) or proprietary. The <a>user agent</a> MUST
NOT support payment handlers unless they include adequate user
consent mechanisms (such as awareness of parties to the transaction
and mechanisms for demonstrating the intention to share data).
In particular, the {{PaymentMethodData}}'s {{PaymentMethodData/data}} and
{{PaymentResponse}}'s {{PaymentResponse/details}} members allow for the arbitrary exchange
of data. In light of the wide range of data models used by existing
payment methods, prescribing data specifics in this API would limit
its usefulness. The {{PaymentResponse/details}} member carries data
from the payment handler, whether Web-based (as defined by the
[[[payment-handler]]]) or proprietary. The [=user agent=] MUST
NOT support payment handlers unless they include adequate user
consent mechanisms (such as awareness of parties to the transaction
and mechanisms for demonstrating the intention to share data).

Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable (as far as proprietary/native payment handlers go), but it still puts the onus on the Payment Handler spec to do the "right thing"™️ with regards to privacy. That's going to be tricky with respect to the .details method because it's opaque to both the user agent and the end user.

@ianbjacobs
Copy link
Collaborator Author

Thank you, @marcoscaceres. I have incorporated your edits into the pull request.

@ianbjacobs ianbjacobs merged commit 0e2ad2b into gh-pages Feb 4, 2021
@ianbjacobs ianbjacobs deleted the privacy-202101 branch October 5, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec is silent on its role in facilitating arbitrary communication between top level contexts
3 participants