Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add navigationId to PerformanceEntry #192

Merged
merged 11 commits into from
Oct 11, 2023
Merged

Add navigationId to PerformanceEntry #192

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
db40939
Add navigationId to PerformanceEntry
clelland Sep 15, 2021
3248985
Move navigation counter to HTML
clelland Oct 1, 2021
cb8dd26
Merge branch 'gh-pages' into add-navigation-id
marcoscaceres Nov 25, 2021
6e5497e
Add proposed update to explainer text
clelland Nov 26, 2021
3adcc6a
Merge branch 'gh-pages' into add-navigation-id
clelland Sep 18, 2022
564c3cb
Add HTML concepts into this doc until they are merged there.
clelland Sep 19, 2022
ec0e067
Merge branch 'gh-pages' into add-navigation-id
clelland Jun 9, 2023
1497e2a
Change navigationId to a string, and add algorithm to queue navigatio…
clelland Apr 24, 2023
8e34f8f
Addressing review comments
clelland Oct 4, 2023
771922d
Introduce an id, and change navigationId to point to it.
clelland Oct 6, 2023
1550c7d
Update explainer, too
clelland Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@
</li>
<li>Exposes {{PerformanceEntry}} in Web Workers [[WORKERS]];
</li>
<li>Formalizes support for multiple navigation events over a document's
lifetime.
</li>
<li>Adds support for {{PerformanceObserver}}.
</li>
</ul>
Expand Down Expand Up @@ -308,6 +311,7 @@ <h2>The <dfn>PerformanceEntry</dfn> interface</h2>
readonly attribute DOMString entryType;
readonly attribute DOMHighResTimeStamp startTime;
readonly attribute DOMHighResTimeStamp duration;
readonly attribute unsigned long navigationId;
[Default] object toJSON();
};</pre>
<dl>
Expand Down Expand Up @@ -344,6 +348,10 @@ <h2>The <dfn>PerformanceEntry</dfn> interface</h2>
duration concept doesn't apply, a performance metric may choose to
return a `duration` of <code>0</code>.
</dd>
<dt><dfn>navigationId</dfn></dt>
<dd>
This attribute MUST return the value of <a>this</a>'s <a>navigationId</a>.
</dd>
</dl>
<p>When <dfn>toJSON</dfn> is called, run [[WebIDL]]'s <a>default toJSON
steps</a>.</p>
Expand Down Expand Up @@ -672,6 +680,17 @@ <h2>Queue a <code>PerformanceEntry</code></h2>
<li>Let <var>relevantGlobal</var> be <var>newEntry</var>'s <a>relevant
global object</a>.
</li>
<li>If <var>relevantGlobal</var>'s <a>environment settings object</a> has a
[=environment settings object/responsible document=]:
<ol>
<li>Set <var>newEntry</var>'s <a
data-lt="PerformanceEntry.navigationId">navigationId</a> to the value of
<var>relevantGlobal</var>'s <a>environment settings object</a>'s [=environment
settings object/responsible document=]'s <a>navigation counter</a>.</li>
</ol>
</li>
<li>Otherwise, set <var>newEntry</var>'s <a
data-lt="PerformanceEntry.navigationId">navigationId</a> to 0.</li>
<li>For each <a>registered performance observer</a> <var>regObs</var> in
<var>relevantGlobal</var>'s <a>list of registered performance observer objects</a>:
<ol>
Expand Down