Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with Permission spec #341

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Integrate with Permission spec #341

merged 2 commits into from
Oct 28, 2021

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Oct 13, 2021

Closes #333
Closes #322

Defers to permission spec to handle permission request and use Permission spec's PermissionState enum instead (it has the same values).

I'm borrowing (ok, stealing👹) the nice definition of "express permission" and moving it to the Permission Spec, so we can use it more widely. Is that ok?

@beverloo, @martinthomson: I need to double-check, but asking for permission from the service worker doesn't seem like it should be possible. We should always say "denied".

The following tasks have been completed:

  • Modified Web platform tests - refactor, so no additional tests needed.

Implementation commitment:


Preview | Diff

@marcoscaceres marcoscaceres marked this pull request as ready for review October 21, 2021 04:48
index.html Show resolved Hide resolved
@marcoscaceres
Copy link
Member Author

marcoscaceres commented Oct 21, 2021

Linking to #322 too... Re: service worker always returning denied.

@marcoscaceres
Copy link
Member Author

Filed Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1737746 and sent patch.

@miketaylr, could you help me with filing the Chromium bug + patch?

@miketaylr
Copy link
Member

@miketaylr, could you help me with filing the Chromium bug + patch?

Yep, sure thing. Filed https://bugs.chromium.org/p/chromium/issues/detail?id=1263499

@marcoscaceres marcoscaceres merged commit 6ed85d1 into gh-pages Oct 28, 2021
@marcoscaceres marcoscaceres deleted the powerful_feature branch October 28, 2021 01:49
pull bot pushed a commit to jamlee-t/chromium that referenced this pull request Oct 29, 2021
The Push API now uses Permission spec's PermissionState enum
(rather than its own PushPermissionState).

Spec PR: w3c/push-api#341.
Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1737746

Change-Id: If9f078293619d28b5094f1601fac2568b9b05793
Bug: 1263499
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245312
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Mike Taylor <miketaylr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#936021}
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
The Push API now uses Permission spec's PermissionState enum
(rather than its own PushPermissionState).

Spec PR: w3c/push-api#341.
Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1737746

Change-Id: If9f078293619d28b5094f1601fac2568b9b05793
Bug: 1263499
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245312
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Mike Taylor <miketaylr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#936021}
NOKEYCHECK=True
GitOrigin-RevId: 57a62d54c739608af3e3c599e6531bcdbd02db19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PushPermissionState and PermissionState are the same Make automatic failing normative
4 participants