-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with Permission spec #341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
commented
Oct 13, 2021
marcoscaceres
commented
Oct 13, 2021
marcoscaceres
force-pushed
the
powerful_feature
branch
from
October 21, 2021 04:52
f0c2fad
to
a053a6f
Compare
martinthomson
approved these changes
Oct 21, 2021
Linking to #322 too... Re: service worker always returning denied. |
beverloo
approved these changes
Oct 25, 2021
Filed Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1737746 and sent patch. @miketaylr, could you help me with filing the Chromium bug + patch? |
Yep, sure thing. Filed https://bugs.chromium.org/p/chromium/issues/detail?id=1263499 |
pull bot
pushed a commit
to jamlee-t/chromium
that referenced
this pull request
Oct 29, 2021
The Push API now uses Permission spec's PermissionState enum (rather than its own PushPermissionState). Spec PR: w3c/push-api#341. Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1737746 Change-Id: If9f078293619d28b5094f1601fac2568b9b05793 Bug: 1263499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245312 Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Mike Taylor <miketaylr@chromium.org> Cr-Commit-Position: refs/heads/main@{#936021}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
The Push API now uses Permission spec's PermissionState enum (rather than its own PushPermissionState). Spec PR: w3c/push-api#341. Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1737746 Change-Id: If9f078293619d28b5094f1601fac2568b9b05793 Bug: 1263499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245312 Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Mike Taylor <miketaylr@chromium.org> Cr-Commit-Position: refs/heads/main@{#936021} NOKEYCHECK=True GitOrigin-RevId: 57a62d54c739608af3e3c599e6531bcdbd02db19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #333
Closes #322
Defers to permission spec to handle permission request and use Permission spec's
PermissionState
enum instead (it has the same values).I'm borrowing (ok, stealing👹) the nice definition of "express permission" and moving it to the Permission Spec, so we can use it more widely. Is that ok?
@beverloo, @martinthomson: I need to double-check, but asking for permission from the service worker doesn't seem like it should be possible. We should always say "denied".
The following tasks have been completed:
Implementation commitment:
Preview | Diff