Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite privacy considerations section #215
Rewrite privacy considerations section #215
Changes from 4 commits
a057762
c05f547
2ee82e0
4dd11d4
625eb62
0d6a585
fed4f26
a02add3
9876fd2
b36ca24
848ec4d
5579b07
64ee33c
b06fc0f
2a2b2ec
c6e3d92
562822d
56642c0
eb30da6
783fc22
afd3b18
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this encourage battery-expensive polling instead? If you support rotating in a way that changes width/height of the viewport I think we should require that something changes. But limiting it two values for type and angle each seems reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I might need to word this better. The answer is "no", because the UA wouldn't fire events when switching from "X-primary" to "X-secondary". Only if "X" changes, would the event fire, but it would always report as "X-primary".
The reason the orientation change event does fire, is that the screen width/height would change, which is already observable either polling
screen
's attribute or simply bymatchMedia("(orientation: landscape)")
.