Remove the note on page visibility handling from WakeLock.request() #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This note was added back in commit 16cd4c7 ("Spec update"), but commit 34119d2 ("Handle document visibility") changed the spec in a way that contradicts the note: we no longer handle visibility changes automatically, and leave it up to script authors to do that instead. Whether this is a good idea or at least be made optional is still being discussed; in the meantime, remove the note since it does not reflect reality. Related to w3c#139
kenchris
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This note was added back in commit 16cd4c7 ("Spec update"), but commit
34119d2 ("Handle document visibility") changed the spec in a way that
contradicts the note: we no longer handle visibility changes automatically,
and leave it up to script authors to do that instead.
Whether this is a good idea or at least be made optional is still being
discussed; in the meantime, remove the note since it does not reflect
reality.
Related to #139
Preview | Diff