Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove browsing context check from WakeLock.request() #363

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Remove browsing context check from WakeLock.request() #363

merged 1 commit into from
Jul 14, 2023

Commits on Jul 14, 2023

  1. Remove browsing context check from WakeLock.request() 

    Since whatwg/html#6315, the HTML spec suggests other specifications use
"navigable" and associated concepts (along with Document) rather than
"browsing context" in most cases.

In this specific case, however, we can simply remove the step that checks if
`document`'s browsing context is null -- there is no case in which a
document is fully active _and_ has a null browsing context, as confirmed by
whatwg/html#9509.

Fixes #362.
    @rakuco
    rakuco committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    79d38db View commit details
    Browse the repository at this point in the history