Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify permissions. #172

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Simplify permissions. #172

merged 1 commit into from
Mar 8, 2017

Conversation

tobie
Copy link
Member

@tobie tobie commented Mar 4, 2017

tobie added a commit to tobie/ambient-light that referenced this pull request Mar 4, 2017
Depends on w3c/permissions#138
Depends on w3c/sensors#172

Needs to be rebased once w3c/permissions#138 has landed.
tobie added a commit to tobie/ambient-light that referenced this pull request Mar 4, 2017
Closes #20.

Depends on w3c/permissions#138
Depends on w3c/sensors#172

Needs to be rebased once w3c/permissions#138 has landed.
@anssiko
Copy link
Member

anssiko commented Mar 8, 2017

LGTM.

Btw. who maintains the awesome pr-preview tool?

@tobie
Copy link
Member Author

tobie commented Mar 8, 2017

Me. :)

@anssiko
Copy link
Member

anssiko commented Mar 8, 2017

Oh, great work! Any plans to roll this out more widely? I've been doing the same manually with http://services.w3.org/htmldiff, which is a pain.

@tobie
Copy link
Member Author

tobie commented Mar 8, 2017

Ping your W3C staff contact. All it needs is a blanket install on the W3C org. WHATWG and WICG are already using it.

@tobie
Copy link
Member Author

tobie commented Mar 8, 2017

That said, maybe there's already a blanket install. Add a config file to check. Details are in the README.

@dontcallmedom
Copy link
Member

I've now made it available to all repos - hopefully it won't be too much to handle for the service. @tobie let me know if it's preferable to make this a per-repo thing.

@tobie
Copy link
Member Author

tobie commented Mar 8, 2017

I'm ooo today, so hopefully it doesn't crash the system when I'm not around.

Repos need to opt-in with a config file however, so it should be fine.

@anssiko
Copy link
Member

anssiko commented Mar 8, 2017

Thanks @dontcallmedom. We try not to crash your amazing service @tobie.

@tobie
Copy link
Member Author

tobie commented Mar 8, 2017

Seems like it's holding up fine so far.

@tobie tobie merged commit 4a46009 into w3c:master Mar 8, 2017
anssiko pushed a commit to w3c/ambient-light that referenced this pull request Mar 14, 2017
Closes #20.

Depends on w3c/permissions#138
Depends on w3c/sensors#172

Needs to be rebased once w3c/permissions#138 has landed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants