Fix up the focused area restrictions. #403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reillyeon
reviewed
Jan 13, 2020
| document. | ||
| [=Sensor readings=] are only available for [=active documents=] whose origin is | ||
| [=same origin-domain=] with the document of the [=currently focused area=] of | ||
| the [=top-level browsing context=] of the specified [=active document=]. |
There was a problem hiding this comment.
I'm not sure which document the "of the specified active document" clause refers to.
There was a problem hiding this comment.
I think that the idea is that, to determine whether sensor readings are available within a particular document, you look at that document's top-level browsing context, find the focused document inside it, and check whether the two documents are same-origin-domain. ... How about:
Suggested change
| the [=top-level browsing context=] of the specified [=active document=]. | |
| the same [=top-level browsing context=]. |
?
|
I ended up fixing this in #483: there's an algorithm that takes a Document, gets its navigable, the navigable's top-level traversable's focusable area's DOM anchor's node document (what a mouthful) and compares each one's relevant settings object's origin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is what you meant. The old text in Mitigations, "the currently focused area document", doesn't have a meaning. The text in "mandatory conditions" was better, but isn't clear about which currently focused area to use, since every top-level browsing context has one.
Preview | Diff