Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "exists" rather than "is present" in dictionary checks. #445

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

rakuco
Copy link
Member

@rakuco rakuco commented Dec 7, 2022

whatwg/webidl#859 removed the "present" and "not present" terms; specs are
supposed to use Infra's "exists" for dictionaries instead.

We had already done this in #440, but there were some leftovers in the
Automation section.

Related to #444.


Preview | Diff

whatwg/webidl#859 removed the "present" and "not present" terms; specs are
supposed to use Infra's "exists" for dictionaries instead.

We had already done this in w3c#440, but there were some leftovers in the
Automation section.

Related to w3c#444.
@rakuco rakuco requested a review from anssiko December 7, 2022 16:18
@kenchris
Copy link
Contributor

kenchris commented Dec 7, 2022

Lgtm

Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of the Automation part too.

@anssiko anssiko merged commit 39ae75f into w3c:main Dec 7, 2022
github-actions bot added a commit that referenced this pull request Dec 7, 2022
SHA: 39ae75f
Reason: push, by anssiko

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@rakuco rakuco deleted the use-exists-not-is-present branch December 7, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants