Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some <dfn>s that were not referenced #465

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

rakuco
Copy link
Member

@rakuco rakuco commented Jul 25, 2023

This fixes Bikeshed warnings like

LINT: Unexported dfn that's not referenced locally - did you mean to export it?
<dfn bs-line-number="550" data-lt="reading value" data-dfn-type="dfn" id="reading-value" data-noexport="by-default">values<a href="#reading-value" class="self-link"></a></dfn>
<dfn bs-line-number="550" data-lt="reading value" data-dfn-type="dfn" id="reading-value" data-noexport="by-default">values<a href="#reading-value" class="self-link"></a></dfn>

Some definitions used to be referenced years ago in previous versions of the
spec text.

While here, also fix

The var 'latest reading' (in algorithm 'update latest reading') is only used once.
If this is not a typo, please add an ignore='' attribute to the <var>.

by referencing the dfn rather than using latest reading as a variable.

Related to #444.


Preview | Diff

This fixes Bikeshed warnings like

    LINT: Unexported dfn that's not referenced locally - did you mean to export it?
    <dfn bs-line-number="550" data-lt="reading value" data-dfn-type="dfn" id="reading-value" data-noexport="by-default">values<a href="#reading-value" class="self-link"></a></dfn>
    <dfn bs-line-number="550" data-lt="reading value" data-dfn-type="dfn" id="reading-value" data-noexport="by-default">values<a href="#reading-value" class="self-link"></a></dfn>

Some definitions used to be referenced years ago in previous versions of the
spec text.

While here, also fix

    The var 'latest reading' (in algorithm 'update latest reading') is only used once.
    If this is not a typo, please add an ignore='' attribute to the <var>.

by referencing the dfn rather than using `latest reading` as a variable.

Related to #444.
@rakuco rakuco requested a review from reillyeon July 25, 2023 21:05
@rakuco rakuco merged commit 34a23e2 into main Jul 26, 2023
1 check passed
@rakuco rakuco deleted the clean-up-unreferenced-dfns branch July 26, 2023 21:41
github-actions bot added a commit that referenced this pull request Jul 26, 2023
SHA: 34a23e2
Reason: push, by rakuco

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants