Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD publication fails due to "wrong-w3c-state-link" error #1887

Closed
anssiko opened this issue Oct 24, 2024 · 6 comments
Closed

CRD publication fails due to "wrong-w3c-state-link" error #1887

anssiko opened this issue Oct 24, 2024 · 6 comments

Comments

@anssiko
Copy link
Member

anssiko commented Oct 24, 2024

@deniak Specberus publication started failing with wrong-w3c-state-link error. It looks the trailing slash at the end of the w3c-state-link URL is the culprit. However, we haven't changed our workflow or bikeshed-boilerplate. Failure first noticed after this commit: webmachinelearning/webnn@d1d71ed

TR fails to deploy: https://www.w3.org/TR/webnn/
ED builds properly: https://webmachinelearning.github.io/webnn/

Specberus Errors:
The link for text "W3C Candidate Recommendation Draft" should pointing to W3C profile "https://www.w3.org/standards/types#CRD", but the link found in the document is "https://www.w3.org/standards/types/#CRD".
{
name: 'headers.w3c-state',
section: 'front-matter',
rule: 'dateState'
}

Details: https://labs.w3.org/echidna/api/status?id=9b0f3878-e95d-48a2-a965-b55dc66c87de

Your Specberus-fu welcome!

@Ms2ger
Copy link

Ms2ger commented Oct 28, 2024

Ref speced/bikeshed#2937

@anssiko
Copy link
Member Author

anssiko commented Oct 31, 2024

@deniak this looks like a Link Checker and Specberus interop issue. Which one is right? The former passes while the latter fails. If Link Checker is correct, I think a Specberus fix might be:

-       const expectedLink = `https://www.w3.org/standards/types#${hash}`;
+       const expectedLink = `https://www.w3.org/standards/types/#${hash}`;

const expectedLink = `https://www.w3.org/standards/types#${hash}`;

@kainino0x
Copy link

I just finally debugged to figure out this is why WebGPU's publish-to-TR step is failing.

IMO the version with the / is better, as
https://www.w3.org/standards/types 301 redirects to
https://www.w3.org/standards/types/.

Would love to see this fixed! I would open a PR with Anssi's fix, however I don't know if simply updating that line will break a bunch of other projects?

@anssiko
Copy link
Member Author

anssiko commented Nov 5, 2024

I believe the fix with tests just landed in #1889 -- thanks @deniak!

@kainino0x
Copy link

Just re-ran the publish job for https://www.w3.org/TR/webgpu/ and it worked! Thank you!

@anssiko
Copy link
Member Author

anssiko commented Nov 6, 2024

Similarly, I can confirm https://www.w3.org/TR/webnn/ publish workflow is green again.

Thanks a bunch @deniak! I'll close this issue.

@anssiko anssiko closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants