Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace proposed-parent-id with child-id. All fields required. #443

Merged
merged 4 commits into from
Jan 26, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Dec 15, 2020

Updates to response header

Fixes #406, #407, #398, #437


Preview | Diff

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is making spec better, suggestion I added is as applicable to previous iteration. So I'm approving this PR with the comment that we may need to discuss whether we need to move soem examples to the processing non-formative section

@dyladan dyladan linked an issue Dec 15, 2020 that may be closed by this pull request
@danielkhan
Copy link
Contributor

I agree with Sergey. Let's wait for 7 days for comments.

@dyladan
Copy link
Member Author

dyladan commented Jan 12, 2021

I agree with Sergey. Let's wait for 7 days for comments.

Has now been 28 days :) would still appreciate reviews from some more WG members.

spec/21-http_response_header_format.md Outdated Show resolved Hide resolved
spec/21-http_response_header_format.md Outdated Show resolved Hide resolved
spec/21-http_response_header_format.md Outdated Show resolved Hide resolved
spec/21-http_response_header_format.md Outdated Show resolved Hide resolved
dyladan and others added 2 commits January 12, 2021 12:18
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@danielkhan danielkhan merged commit 5634149 into w3c:master Jan 26, 2021
@dyladan dyladan deleted the child-id-update branch January 26, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants