Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrote DOM integration #418

Merged
merged 9 commits into from
Feb 1, 2024
Merged

Rewrote DOM integration #418

merged 9 commits into from
Feb 1, 2024

Conversation

koto
Copy link
Member

@koto koto commented Jan 23, 2024

This adds an entry point algorithm to call from DOM's append, change, and replace algorithms for Attr nodes.

whatwg/dom#789
Closes #401.

@koto koto force-pushed the dom branch 2 times, most recently from 7820b21 to 6702593 Compare January 23, 2024 15:15
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't restudied the wider context, but I have some comments even without context. Hope they are helpful.

spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
koto added a commit to koto/dom that referenced this pull request Jan 23, 2024
spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This green bit looks pretty solid to me now (modulo test coverage).

spec/index.bs Outdated Show resolved Hide resolved
Copy link
Collaborator

@mbrodesser-Igalia mbrodesser-Igalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't add an inline comment for https://github.com/w3c/trusted-types/pull/418/files#diff-40cc3a1ba233cc3ca7b6d5873260da9676f6ae20bb897b62f7871c80d0bda4e9R1060-L1059, hence here: don't those lines imply

someIframe.setAttribute("srcdoc", "someHtml");

would set the srcdoc's value to "someHtml", because someIframe's global differs from the embedding document's global?

Asking because of #425 (comment).

CC @koto

@koto
Copy link
Member Author

koto commented Jan 29, 2024

don't those lines imply

someIframe.setAttribute("srcdoc", "someHtml");

would set the srcdoc's value to "someHtml", because someIframe's global differs from the embedding document's global?

Isn't iframe element global the same? Only its content window can have a different global.

@mbrodesser-Igalia
Copy link
Collaborator

don't those lines imply

someIframe.setAttribute("srcdoc", "someHtml");

would set the srcdoc's value to "someHtml", because someIframe's global differs from the embedding document's global?

Isn't iframe element global the same?

It should be. Thanks for the context.

Only its content window can have a different global.

@koto koto merged commit d5d9ee9 into w3c:main Feb 1, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Feb 1, 2024
SHA: d5d9ee9
Reason: push, by koto

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
koto added a commit to koto/dom that referenced this pull request Feb 26, 2024
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 14, 2024
… for `setAttributeNS` to `null`, a=testonly

Automatic update from web-platform-tests
Change namespace for Trusted-Types tests for `setAttributeNS` to `null`

See
<w3c/trusted-types#418 (comment)>
and
<w3c/trusted-types#418 (comment)>.

Preparation to fix <w3c/trusted-types#425>.

--

wpt-commits: f823803bb10d628a2b09a3e76b602c9d9f7866b9
wpt-pr: 44699
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Mar 17, 2024
… for `setAttributeNS` to `null`, a=testonly

Automatic update from web-platform-tests
Change namespace for Trusted-Types tests for `setAttributeNS` to `null`

See
<w3c/trusted-types#418 (comment)>
and
<w3c/trusted-types#418 (comment)>.

Preparation to fix <w3c/trusted-types#425>.

--

wpt-commits: f823803bb10d628a2b09a3e76b602c9d9f7866b9
wpt-pr: 44699
lukewarlow pushed a commit to lukewarlow/dom that referenced this pull request Apr 11, 2024
lukewarlow pushed a commit to lukewarlow/dom that referenced this pull request Apr 22, 2024
lukewarlow pushed a commit to lukewarlow/dom that referenced this pull request May 16, 2024
lukewarlow pushed a commit to lukewarlow/dom that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is the [[ScriptURL]] slot needed?
4 participants