-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrote DOM integration #418
Conversation
7820b21
to
6702593
Compare
call from DOM. whatwg/dom#789 Closes w3c#401.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't restudied the wider context, but I have some comments even without context. Hope they are helpful.
See w3c/trusted-types#418 and whatwg#789. Supercedes PR whatwg#809.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This green bit looks pretty solid to me now (modulo test coverage).
This fixes an error with default policy handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't add an inline comment for https://github.com/w3c/trusted-types/pull/418/files#diff-40cc3a1ba233cc3ca7b6d5873260da9676f6ae20bb897b62f7871c80d0bda4e9R1060-L1059, hence here: don't those lines imply
someIframe.setAttribute("srcdoc", "someHtml");
would set the srcdoc's value to "someHtml", because someIframe
's global differs from the embedding document's global?
Asking because of #425 (comment).
CC @koto
Isn't iframe element global the same? Only its content window can have a different global. |
It should be. Thanks for the context.
|
SHA: d5d9ee9 Reason: push, by koto Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
See w3c/trusted-types#418 and whatwg#789. Supercedes PR whatwg#809.
… for `setAttributeNS` to `null`, a=testonly Automatic update from web-platform-tests Change namespace for Trusted-Types tests for `setAttributeNS` to `null` See <w3c/trusted-types#418 (comment)> and <w3c/trusted-types#418 (comment)>. Preparation to fix <w3c/trusted-types#425>. -- wpt-commits: f823803bb10d628a2b09a3e76b602c9d9f7866b9 wpt-pr: 44699
… for `setAttributeNS` to `null`, a=testonly Automatic update from web-platform-tests Change namespace for Trusted-Types tests for `setAttributeNS` to `null` See <w3c/trusted-types#418 (comment)> and <w3c/trusted-types#418 (comment)>. Preparation to fix <w3c/trusted-types#425>. -- wpt-commits: f823803bb10d628a2b09a3e76b602c9d9f7866b9 wpt-pr: 44699
See w3c/trusted-types#418 and whatwg#789. Supercedes PR whatwg#809.
See w3c/trusted-types#418 and whatwg#789. Supercedes PR whatwg#809.
See w3c/trusted-types#418 and whatwg#789. Supercedes PR whatwg#809.
See w3c/trusted-types#418 and whatwg#789. Supercedes PR whatwg#809.
This adds an entry point algorithm to call from DOM's append, change, and replace algorithms for Attr nodes.
whatwg/dom#789
Closes #401.