Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate VC-JWT section to dedicated specification. #899

Merged
merged 2 commits into from
Aug 14, 2022
Merged

Conversation

msporny
Copy link
Member

@msporny msporny commented Jul 30, 2022

This PR migrates the VC-JWT section in the VC data model specification to a dedicated specification. The corresponding PR into the destination specification can be found here: w3c/vc-jose-cose#1


Preview | Diff

@msporny msporny added the substantive Substantive changes to the specification. label Jul 30, 2022
Copy link
Contributor

@peacekeeper peacekeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to #900, I assume this is done after FPWD is out and the actual JWT-related content has been moved into the VC-JWT spec.

@peacekeeper
Copy link
Contributor

Should this PR also update the following reference?

elaborated on in Section <a href="#json-web-token"></a>. An <dfn>embedded

@msporny
Copy link
Member Author

msporny commented Jul 31, 2022

Should this PR also update the following reference?

Good catch, yes it should. I'll make that update before merging.

Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msporny
Copy link
Member Author

msporny commented Aug 14, 2022

@peacekeeper wrote:

Should this PR also update the following reference?

elaborated on in Section <a href="#json-web-token"></a>. An <dfn>embedded

Fixed in 775af20.

@msporny
Copy link
Member Author

msporny commented Aug 14, 2022

Substantive, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 893fa58 into main Aug 14, 2022
@msporny msporny deleted the msporny-move-jwt branch August 14, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
substantive Substantive changes to the specification.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants