-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose "instead of" in terms of media type #41
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -519,12 +519,14 @@ <h6>JWT Decoding</h6> | |
</section> | ||
</section> | ||
|
||
<section id="version-1.1"> | ||
<h2>Version 1.1</h2> | ||
<section id="production"> | ||
<h2>Production</h2> | ||
|
||
<p> | ||
This section describes how to produce a VC-JWT encoded | ||
<code>VerifiableCredential</code> from a <code>Credential</code>. | ||
<code>VerifiableCredential</code> from an object of media type <code>application/credential+ld+json</code>. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. replace ambiguous "Credential" with specific media type, this change is potentially blocked by w3c/vc-data-model#1014 If that PR changes substantially, this PR will need to be rejected / reworked. |
||
</p> | ||
|
||
<p class="advisment"> | ||
|
@@ -540,14 +542,14 @@ <h3>In addition to...</h3> | |
|
||
<p> | ||
There are several members (claims) of the | ||
<code>Credential</code> which will need to be translated to their JOSE | ||
<code>application/credential+ld+json</code> which will need to be translated to their JOSE | ||
form, and included next to the <code>vc</code> or | ||
<code>vp</code> member in the JWT Claims Set. | ||
We refer to the JWT Claims Set as <code>payload</code> in this section. | ||
</p> | ||
|
||
<p> | ||
If a member is not present in the <code>Credential</code> it MUST NOT | ||
If a member is not present in the <code>application/credential+ld+json</code> it MUST NOT | ||
be present in the <code>VerifiableCredential</code> as either a claim | ||
in the payload or a claim in the <code>vc</code> attribute of the | ||
payload. | ||
|
@@ -556,7 +558,7 @@ <h3>In addition to...</h3> | |
<p> | ||
We start with an empty header, and payload objects, and we add members | ||
to the header and the payload based on the content in the | ||
<code>Credential</code>. | ||
<code>application/credential+ld+json</code>. | ||
</p> | ||
|
||
<section> | ||
|
@@ -621,10 +623,30 @@ <h4>issuance</h4> | |
|
||
<section> | ||
<h3>Instead of...</h3> | ||
<p class="issue">This section needs to be defined.</p> | ||
<p> | ||
The following steps are one way to obtain this representation: | ||
</p> | ||
<ol> | ||
<li> | ||
Complete the mapping for <a href="#in-addition-to">In Addition To...</a>. | ||
</li> | ||
<li> | ||
Remove any properties from the <code>application/credential+ld+json</code> that were mapped. | ||
</li> | ||
<li> | ||
Set the resulting object to be the <code>vc</code> member of the claim set. | ||
</li> | ||
</ol> | ||
|
||
<p class="note"> | ||
The object value for the <code>vc</code> property, | ||
when <a href="#instead-of">Instead of...</a> production rules have been applied, | ||
is not of media type <code>application/credential+ld+json</code>. | ||
</p> | ||
|
||
</section> | ||
</section> | ||
|
||
</section> | ||
<section> | ||
<h2>Privacy Considerations</h2> | ||
</section> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a section so we can distinguish between production rules for 1.1 and potential production rules for future versions