Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404s to html asset pages #187

Merged
merged 6 commits into from
Feb 1, 2023
Merged

Fix 404s to html asset pages #187

merged 6 commits into from
Feb 1, 2023

Conversation

alflennik
Copy link
Contributor

Fixes issue #186.

@netlify
Copy link

netlify bot commented Feb 1, 2023

Deploy Preview for aria-practices ready!

Name Link
🔨 Latest commit 1a1ab06
🔍 Latest deploy log https://app.netlify.com/sites/aria-practices/deploys/63dadf190b5cce0008e45fa2
😎 Deploy Preview https://deploy-preview-187--aria-practices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@howard-e
Copy link
Contributor

howard-e commented Feb 1, 2023

@alflennik thanks for addressing that so quickly. Ran through the list directly and also getting to them from the application as well and it looks good for the most part but still 2 concerns here:

@howard-e
Copy link
Contributor

howard-e commented Feb 1, 2023

@alflennik I see your comment on now so this can be ignored.

@alflennik
Copy link
Contributor Author

About /patterns/landmarks/examples/index, this page was renamed to general-principles.html to avoid confusion with the other pages called index.html. Do you find any references to that old page? If so you may have found a bug.

Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The rating icons are still broken for the feedDisplay example. It seems to be moved to an unexpected path when built on the wai-website repo but I we can follow up with a PR to fix that afterwards

@alflennik alflennik merged commit 1280d01 into main Feb 1, 2023
@remibetin remibetin deleted the html-assets branch November 19, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants