-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 404s to html asset pages #187
Conversation
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@alflennik thanks for addressing that so quickly. Ran through the list directly and also getting to them from the application as well and it looks good for the most part but still 2 concerns here:
|
@alflennik I see your comment on now so this can be ignored. |
About /patterns/landmarks/examples/index, this page was renamed to general-principles.html to avoid confusion with the other pages called index.html. Do you find any references to that old page? If so you may have found a bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The rating icons are still broken for the feedDisplay example. It seems to be moved to an unexpected path when built on the wai-website repo but I we can follow up with a PR to fix that afterwards
Fixes issue #186.