Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapped SWAN.community proposal to use cases. #113

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jwrosewell
Copy link
Contributor

Abbreviated to SWAN.co and added new lines to tables as markdown table cells are single line only. We may be better changing the format of the table as other proposals are mapped to the use cases.

Asking @benjaminsavage to review as original author.

Abbreviated to SWAN.co and added new lines to tables as markdown table cells are single line only. We may be better changing the format of the table as other proposals are mapped to the use cases.
Copy link

@TheMaskMaker TheMaskMaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see proposals adding their use cases to this!

Was wondering if SWAN should be a separate category column? It is a proposal that addresses many use cases and I am concerned the community proposals box will overfill.

@AramZS
Copy link
Member

AramZS commented Apr 28, 2021

Hi, I'm not sure that adding the proposal as separate new rows for just a single new proposal per case is how we've handled things, can you update so that it is separated in the community column by a line-break and not a full new row?

@jwrosewell
Copy link
Contributor Author

My markdown editor (Visual Studio Code) doesn't seem to like multi line table cells. Anyone know of an editor that does support?

… row per project. Addresses issues associated with extending the original format to include many community proposals and limitations of Markdown tables.

Other formatting changes included to improve markdown structure.
@jwrosewell
Copy link
Contributor Author

@AramZS @benjaminsavage Could you both review the restructured layout ahead of merging? This was the best option I could come up with to enable many other proposals to be added to the document. The % column in the tables for each use case can be used to indicate the % fit for each proposal to the use case.

@TheMaskMaker
Copy link

My concern about the adding swan to its own category has been addressed. Thank you @jwrosewell.

I'm not sure how the % will work, but seems easy enough to remove later if it doesn't. Could possibly have some correlation to the buy-in document Ben mentioned?

@benjaminsavage I have no objections to the pr as is. Would prefer this get merged sooner so we don't accidentally lose use cases if folks add before the columnar refactor.

@AramZS
Copy link
Member

AramZS commented May 25, 2021

Recording notes from the meeting, I think we all agree that the percent column doesn't make sense in this context.

Adding: I agree that as community proposals grow having a single column isn't great, but also community proposals do not have the same possibility of adoption as browser proposals. I wonder if there are issues weighting it in this way or readability. I do like the idea of the use cases and what addresses them being more consumable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants