Better log messages for canShare #226
Conversation
| @@ -118,10 +118,20 @@ <h1> | |||
| textfield.value = ''; | |||
| } | |||
|
|
|||
| function checkBasicFileShare() { | |||
| // XXX: There is no straightforward API to do this. | |||
There was a problem hiding this comment.
I think this is a problem, as already mentioned in #108 (comment). Something like this would help.
navigator.canShare("files"); // basic feature support
navigator.canShare("files", [files]); // matches canShare({files});I believe this form of API is discussed somewhere around TPAC 2020 but can't find the log.
There was a problem hiding this comment.
#184 was about canShareFiles with file types, but since Blink is now also checking file sizes, I guess receiving a sequence of files is needed?
There was a problem hiding this comment.
canShare in Blink seemingly has no check for file types nor file sizes, and share() somehow throws PermissionError instead when it receives an unsupported file or too large file. Maybe to prevent fingerprinting? But then what's the point of canShare with the current form? 👀
There was a problem hiding this comment.
hehe, "incremental improvement"?
Related to #222